Closed Bug 1393790 Opened 3 years ago Closed 3 years ago

Remove getter/setter stubs

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(2 files)

Part 1 - Remove JS_STUBGETTER and JS_STUBSETTER
21.35 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
Part 2 - Remove JS_PropertyStub and JS_StrictPropertyStub
14.98 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review 
Their only purpose was to distinguish "class getter/setter" vs "no getter/setter", but with class getters/setters gone (bug 1389510), we can remove JS_PropertyStub and JS_StrictPropertyStub.
Jason, you get to review this since you did a lot of the work removing these.
Attachment #8901191 - Flags: review?(jorendorff)
Comment on attachment 8901191 [details] [diff] [review]
Part 1 - Remove JS_STUBGETTER and JS_STUBSETTER

Review of attachment 8901191 [details] [diff] [review]:
-----------------------------------------------------------------

Beautiful!
Attachment #8901191 - Flags: review?(jorendorff) → review+
Attachment #8901194 - Flags: review?(jorendorff) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1cf11762a24
part 1 - Remove JS_STUBGETTER and JS_STUBSETTER. r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb7113a86e9b
part 2 - Remove JS_PropertyStub and JS_StrictPropertyStub. r=jorendorff
https://hg.mozilla.org/mozilla-central/rev/f1cf11762a24
https://hg.mozilla.org/mozilla-central/rev/fb7113a86e9b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.