Closed
Bug 1393790
Opened 8 years ago
Closed 8 years ago
Remove getter/setter stubs
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(2 files)
21.35 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
14.98 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Their only purpose was to distinguish "class getter/setter" vs "no getter/setter", but with class getters/setters gone (bug 1389510), we can remove JS_PropertyStub and JS_StrictPropertyStub.
Assignee | ||
Comment 1•8 years ago
|
||
Jason, you get to review this since you did a lot of the work removing these.
Attachment #8901191 -
Flags: review?(jorendorff)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8901194 -
Flags: review?(jorendorff)
Comment 3•8 years ago
|
||
Comment on attachment 8901191 [details] [diff] [review]
Part 1 - Remove JS_STUBGETTER and JS_STUBSETTER
Review of attachment 8901191 [details] [diff] [review]:
-----------------------------------------------------------------
Beautiful!
Attachment #8901191 -
Flags: review?(jorendorff) → review+
Updated•8 years ago
|
Attachment #8901194 -
Flags: review?(jorendorff) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1cf11762a24
part 1 - Remove JS_STUBGETTER and JS_STUBSETTER. r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb7113a86e9b
part 2 - Remove JS_PropertyStub and JS_StrictPropertyStub. r=jorendorff
![]() |
||
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f1cf11762a24
https://hg.mozilla.org/mozilla-central/rev/fb7113a86e9b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•