Remove getter/setter stubs

RESOLVED FIXED in Firefox 57

Status

()

Core
JavaScript Engine
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 months ago
Their only purpose was to distinguish "class getter/setter" vs "no getter/setter", but with class getters/setters gone (bug 1389510), we can remove JS_PropertyStub and JS_StrictPropertyStub.
(Assignee)

Comment 1

11 months ago
Created attachment 8901191 [details] [diff] [review]
Part 1 - Remove JS_STUBGETTER and JS_STUBSETTER

Jason, you get to review this since you did a lot of the work removing these.
Attachment #8901191 - Flags: review?(jorendorff)
(Assignee)

Comment 2

11 months ago
Created attachment 8901194 [details] [diff] [review]
Part 2 - Remove JS_PropertyStub and JS_StrictPropertyStub
Attachment #8901194 - Flags: review?(jorendorff)
Comment on attachment 8901191 [details] [diff] [review]
Part 1 - Remove JS_STUBGETTER and JS_STUBSETTER

Review of attachment 8901191 [details] [diff] [review]:
-----------------------------------------------------------------

Beautiful!
Attachment #8901191 - Flags: review?(jorendorff) → review+
Attachment #8901194 - Flags: review?(jorendorff) → review+

Comment 4

11 months ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1cf11762a24
part 1 - Remove JS_STUBGETTER and JS_STUBSETTER. r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb7113a86e9b
part 2 - Remove JS_PropertyStub and JS_StrictPropertyStub. r=jorendorff
https://hg.mozilla.org/mozilla-central/rev/f1cf11762a24
https://hg.mozilla.org/mozilla-central/rev/fb7113a86e9b
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.