Closed Bug 1393799 Opened 2 years ago Closed 2 years ago

[Form Autofill] The red border of the invalid email box is incomplete

Categories

(Toolkit :: Form Manager, defect, minor)

56 Branch
defect
Not set
minor

Tracking

()

VERIFIED FIXED
mozilla57
Tracking Status
firefox56 --- verified
firefox57 --- verified

People

(Reporter: zstimi, Assigned: scottwu)

Details

(Whiteboard: [form autofill])

Attachments

(3 files)

Attached image EmailBox.PNG
[Environment:]
Windows 8.1 x64, Mac Osx 10.11

56.0b6 20170825011442

[Steps:]

Preconditions
Go to Preferences/ Privacy and Security / Form Autofill / Enable Profile autofill. (default in Nightly)
Make sure you have at least one saved address.

1. Open Firefox
2. Add addresses, in Email box put an invalid email
3. Save the address
4. Edit the address with invalid email

[Actual Result:]
The red border of the email box is incomplete on  the right side.


[Expected Result:]
The border of the email box is red all around.
Whiteboard: [form autofill]
Scott is going to look into it.
Assignee: nobody → scwwu
Comment on attachment 8902547 [details]
Bug 1393799 - Add extra space around forms to ensure invalid fields are displayed properly.

https://reviewboard.mozilla.org/r/174148/#review179400
Attachment #8902547 - Flags: review?(lchang) → review+
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7adf0301c546
Add extra space around forms to ensure invalid fields are displayed properly. r=lchang
Rebased for beta uplift: since editDialog.css does not exist in beta 46, the padding rule is added to editAddress.css instead.
Attachment #8902613 - Flags: review?(lchang)
Attachment #8902613 - Flags: review?(lchang) → review+
https://hg.mozilla.org/mozilla-central/rev/7adf0301c546
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment on attachment 8902613 [details] [diff] [review]
Bug 1393799 - Patch for beta 46

Approval Request Comment
[Feature/Bug causing the regression]:
Not a regression. Bug exists since 1019471, when the feature first landed.
[User impact if declined]:
Users would notice the border on the right is missing when entering an invalid email address.
[Is this code covered by automated tests?]:
No. Page layout is not covered in tests.
[Has the fix been verified in Nightly?]:
Yes I can verify that it's been fixed on Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: 
No.
[List of other uplifts needed for the feature/fix]:
None.
[Is the change risky?]:
No.
[Why is the change risky/not risky?]:
The style change is minor and only affects editAddress.xhtml
[String changes made/needed]:
None.
Attachment #8902613 - Flags: approval-mozilla-beta?
Comment on attachment 8902613 [details] [diff] [review]
Bug 1393799 - Patch for beta 46

Minor fix for auto formfill, should be fine to uplift for beta 8.
Attachment #8902613 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed under Windows 10x64 and macOS 10.12 using 56.0 20170918210324 and 57.0a1.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.