Closed Bug 1393859 Opened 2 years ago Closed 2 years ago

The menu does not work correctly for reader mode pages

Categories

(Firefox for iOS :: Menu and Toolbar, defect, P1)

Other
iOS
defect

Tracking

()

RESOLVED FIXED
Iteration:
1.30
Tracking Status
fxios 10.0 ---

People

(Reporter: farhan, Assigned: farhan)

References

Details

(Whiteboard: [Photon][MobileCore])

Attachments

(1 file)

55 bytes, text/x-github-pull-request
garvan
: review+
Details | Review
The share button is enabled for reading mode but pressing it does nothing. 

Right now, The Action sheet does not work on local pages. Enabling it on reader mode pages should not expose the localhost urls. 

Saving / Bookmarking and sharing should all be done on the original URL and not the readermode url.
Summary: The menu does not work correctly for reading mode pages → The menu does not work correctly for reader mode pages
Instead use the urls displayURL property it correctly parses out all of our localhost properties.
Attached file Pull Request
Attachment #8908881 - Flags: review?(gkeeley)
Assignee: nobody → fpatel
Iteration: --- → 1.30
Priority: -- → P1
Whiteboard: [Photon] → [Photon][MobileCore]
Attachment #8908881 - Flags: review?(gkeeley) → review+
master https://github.com/mozilla-mobile/firefox-ios/commit/759900a0a0bf48e3616fdba2528cd44a0af0342c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.