Closed
Bug 1393859
Opened 8 years ago
Closed 8 years ago
The menu does not work correctly for reader mode pages
Categories
(Firefox for iOS :: Menu and Toolbar, defect, P1)
Tracking
()
RESOLVED
FIXED
Iteration:
1.30
| Tracking | Status | |
|---|---|---|
| fxios | 10.0 | --- |
People
(Reporter: farhan, Assigned: farhan)
References
Details
(Whiteboard: [Photon][MobileCore])
Attachments
(1 file)
The share button is enabled for reading mode but pressing it does nothing.
Right now, The Action sheet does not work on local pages. Enabling it on reader mode pages should not expose the localhost urls.
Saving / Bookmarking and sharing should all be done on the original URL and not the readermode url.
|
Assignee | |
Updated•8 years ago
|
Summary: The menu does not work correctly for reading mode pages → The menu does not work correctly for reader mode pages
|
|
Assignee | |
Comment 1•8 years ago
|
||
Instead use the urls displayURL property it correctly parses out all of our localhost properties.
|
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8908881 -
Flags: review?(gkeeley)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → fpatel
Iteration: --- → 1.30
Priority: -- → P1
Whiteboard: [Photon] → [Photon][MobileCore]
Attachment #8908881 -
Flags: review?(gkeeley) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
master https://github.com/mozilla-mobile/firefox-ios/commit/759900a0a0bf48e3616fdba2528cd44a0af0342c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•