Closed
Bug 1393909
Opened 7 years ago
Closed 7 years ago
Remove sync messaging in WebRequestContent
Categories
(WebExtensions :: Request Handling, enhancement, P1)
Tracking
(Performance Impact:high, firefox57 fixed)
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
WebRequestContent uses sync messaging if we have blocking listeners. With legacy addons removed in 57, this is no longer necessary since WebExtensions cannot make use of it. Lets remove those bits of code so the messaging is all async.
|
||
Updated•7 years ago
|
| Comment hidden (mozreview-request) |
|
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8901308 [details]
Bug 1393909 remove sync messaging from WebRequest,
https://reviewboard.mozilla.org/r/172754/#review178184
r=me if tests pass.
There might still be some legacy WebRequest.jsm tests that rely on this. If so, we should just disable them.
Attachment #8901308 -
Flags: review?(kmaglione+bmo) → review+
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Kris Maglione [:kmag] from comment #2)
> There might still be some legacy WebRequest.jsm tests that rely on this. If
> so, we should just disable them.
I ran what I could find local and they passed. should hopefully catch anything else on try.
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e1d63de12f2c
remove sync messaging from WebRequest, r=kmag
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
|
||
Updated•3 years ago
|
Performance Impact: --- → P1
Whiteboard: [qf:p1]
You need to log in
before you can comment on or make changes to this bug.
Description
•