Remove sync messaging in WebRequestContent

RESOLVED FIXED in Firefox 57

Status

enhancement
P1
normal
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

(Blocks 2 bugs)

49 Branch
mozilla57
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [qf:p1])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
WebRequestContent uses sync messaging if we have blocking listeners.  With legacy addons removed in 57, this is no longer necessary since WebExtensions cannot make use of it.  Lets remove those bits of code so the messaging is all async.
Blocks: webext-perf
Priority: P3 → P1
Whiteboard: [qf:p1]
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8901308 [details]
Bug 1393909 remove sync messaging from WebRequest,

https://reviewboard.mozilla.org/r/172754/#review178184

r=me if tests pass.

There might still be some legacy WebRequest.jsm tests that rely on this. If so, we should just disable them.
Attachment #8901308 - Flags: review?(kmaglione+bmo) → review+
(Assignee)

Comment 3

2 years ago
(In reply to Kris Maglione [:kmag] from comment #2)

> There might still be some legacy WebRequest.jsm tests that rely on this. If
> so, we should just disable them.

I ran what I could find local and they passed.  should hopefully catch anything else on try.

Comment 4

2 years ago
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e1d63de12f2c
remove sync messaging from WebRequest, r=kmag

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e1d63de12f2c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57

Updated

2 years ago
Blocks: SyncIPC

Updated

10 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.