Closed Bug 1393909 Opened 3 years ago Closed 3 years ago

Remove sync messaging in WebRequestContent

Categories

(WebExtensions :: Request Handling, enhancement, P1)

49 Branch
enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [qf:p1])

Attachments

(1 file)

WebRequestContent uses sync messaging if we have blocking listeners.  With legacy addons removed in 57, this is no longer necessary since WebExtensions cannot make use of it.  Lets remove those bits of code so the messaging is all async.
Blocks: webext-perf
Priority: P3 → P1
Whiteboard: [qf:p1]
Comment on attachment 8901308 [details]
Bug 1393909 remove sync messaging from WebRequest,

https://reviewboard.mozilla.org/r/172754/#review178184

r=me if tests pass.

There might still be some legacy WebRequest.jsm tests that rely on this. If so, we should just disable them.
Attachment #8901308 - Flags: review?(kmaglione+bmo) → review+
(In reply to Kris Maglione [:kmag] from comment #2)

> There might still be some legacy WebRequest.jsm tests that rely on this. If
> so, we should just disable them.

I ran what I could find local and they passed.  should hopefully catch anything else on try.
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e1d63de12f2c
remove sync messaging from WebRequest, r=kmag
https://hg.mozilla.org/mozilla-central/rev/e1d63de12f2c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: SyncIPC
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.