1393915 - Deduplicate consecutive "(content script)" frames in BHR

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Deduplicate consecutive (content script) frames

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8901303 [details] [diff] [review]
Deduplicate consecutive (content script) frames

Review of attachment 8901303 [details] [diff] [review]:
-----------------------------------------------------------------

The below can be done in a followup if you're interested in exploring it.

::: toolkit/components/backgroundhangmonitor/ThreadStackHelper.cpp
@@ +266,5 @@
>    if (!IsChromeJSScript(aEntry.script())) {
> +    // NOTE: Deduplicate consecutive (content script) frames.
> +    if (backFrame &&
> +        backFrame->GetKind() == HangStack::Frame::Kind::STRING &&
> +        !strcmp(backFrame->AsString(), "(content script)")) {

I agree that this does what you want...but I'm wondering if we could add another Frame::Kind for CONTENT_SCRIPT or something so we wouldn't have to deal with a string comparison every time.

Same goes for other string frames (e.g. do we want to deduplicate "(profiling suppressed)" above?  do we want to add a Frame::Kind for it?  etc.)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbefb75a8098
Deduplicate consecutive (content script) frames, r=froydnj

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bbefb75a8098