Closed Bug 1393928 Opened 2 years ago Closed 2 years ago

Expose intl/l10n .jsm APIs explicitly

Categories

(Core :: Internationalization, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

As :mossop pointed out in bug 1347799 we need to explicitly expose names in Localization.jsm, L10nRegistry.jsm and MessageContext.jsm to get it on the lazy-load list.

Which is exactly what we need in bug 1365709 :)
Assignee: nobody → gandalf
Blocks: 1365709
Status: NEW → ASSIGNED
Comment on attachment 8901316 [details]
Bug 1393928 - Expose intl/l10n .jsm APIs explicitly.

https://reviewboard.mozilla.org/r/172762/#review178180

::: intl/l10n/L10nRegistry.jsm:346
(Diff revision 1)
>  
>  this.L10nRegistry = L10nRegistry;
>  this.FileSource = FileSource;
>  this.IndexedFileSource = IndexedFileSource;
>  
> -this.EXPORTED_SYMBOLS = [];
> +this.EXPORTED_SYMBOLS = ['L10nRegistry', 'FileSource', 'IndexedFileSource'];

Can you also update the linting info at https://dxr.mozilla.org/mozilla-central/source/tools/lint/eslint/modules.json
Attachment #8901316 - Flags: review?(dtownsend) → review+
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f7fc9705557
Expose intl/l10n .jsm APIs explicitly. r=mossop
https://hg.mozilla.org/mozilla-central/rev/2f7fc9705557
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.