1393928 - Expose intl/l10n .jsm APIs explicitly

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

As :mossop pointed out in bug 1347799 we need to explicitly expose names in Localization.jsm, L10nRegistry.jsm and MessageContext.jsm to get it on the lazy-load list.

Which is exactly what we need in bug 1365709 :)

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1393928 - Expose intl/l10n .jsm APIs explicitly.

Review commit: https://reviewboard.mozilla.org/r/172762/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172762/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8901316 [details]
Bug 1393928 - Expose intl/l10n .jsm APIs explicitly.

https://reviewboard.mozilla.org/r/172762/#review178180

::: intl/l10n/L10nRegistry.jsm:346
(Diff revision 1)
>  
>  this.L10nRegistry = L10nRegistry;
>  this.FileSource = FileSource;
>  this.IndexedFileSource = IndexedFileSource;
>  
> -this.EXPORTED_SYMBOLS = [];
> +this.EXPORTED_SYMBOLS = ['L10nRegistry', 'FileSource', 'IndexedFileSource'];

Can you also update the linting info at https://dxr.mozilla.org/mozilla-central/source/tools/lint/eslint/modules.json

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8901316 [details]
Bug 1393928 - Expose intl/l10n .jsm APIs explicitly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172762/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f7fc9705557
Expose intl/l10n .jsm APIs explicitly. r=mossop

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2f7fc9705557