1393967 - stylo: update cssparser to verison 0.19.5 (and some other dependencies)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Simon Sapin (:SimonSapin)]

This is needed ahead of landing https://github.com/servo/servo/pull/18171 because that changes a dependency requirement to a version greater than currently used in Gecko’s Cargo.lock file, which causes `./mach vendor rust` to fail.

Comment 1

[Simon Sapin (:SimonSapin)]

Attachment: Bug 1393967 - Update cssparser to verison 0.19.5 (and some other dependencies)

Review commit: https://reviewboard.mozilla.org/r/172796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172796/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8901338 [details]
Bug 1393967 - Update cssparser to verison 0.19.5 (and some other dependencies)

https://reviewboard.mozilla.org/r/172796/#review178200

r=me as far as it passes tests.

Comment 3

[Simon Sapin (:SimonSapin)]

Thanks Xidorn.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0078d3c5804eff9eef80997af1335fe927adc662 looks green enough.

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 50eb665383d0 -d 59352665f357: rebasing 415932:50eb665383d0 "Bug 1393967 - Update cssparser to verison 0.19.5 (and some other dependencies) r=xidorn" (tip)
merging toolkit/library/gtest/rust/Cargo.lock
merging toolkit/library/rust/Cargo.lock
warning: conflicts while merging toolkit/library/gtest/rust/Cargo.lock! (edit, then use 'hg resolve --mark')
warning: conflicts while merging toolkit/library/rust/Cargo.lock! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Simon Sapin (:SimonSapin)]

Comment on attachment 8901338 [details]
Bug 1393967 - Update cssparser to verison 0.19.5 (and some other dependencies)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172796/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62cf6d3a7b94
Update cssparser to verison 0.19.5 (and some other dependencies) r=xidorn

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/62cf6d3a7b94

Comment 8

[Ionuț Goldan [:igoldan]]

== Change summary for alert #9026 (as of August 25 2017 23:14 UTC) ==

Improvements:

 25%  Stylo Servo_DeclarationBlock_SetPropertyById_WithInitialSpace_Bench osx-10-10 opt      708,543.17 -> 529,087.33
 11%  Stylo Servo_StyleSheet_FromUTF8Bytes_Bench osx-10-10 opt                               87,558.17 -> 77,858.75

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=9026

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

and more!

== Change summary for alert #9034 (as of August 26 2017 00:16 UTC) ==

Improvements:

 29%  Stylo Servo_DeclarationBlock_SetPropertyById_WithInitialSpace_Bench windows7-32 opt      683,468.17 -> 482,187.25
 28%  Stylo Servo_DeclarationBlock_SetPropertyById_WithInitialSpace_Bench windows10-64 opt     616,064.75 -> 443,617.00
 13%  Stylo Servo_StyleSheet_FromUTF8Bytes_Bench windows10-64 opt                              71,487.33 -> 62,278.17
 13%  Stylo Servo_StyleSheet_FromUTF8Bytes_Bench windows7-32 opt                               78,875.33 -> 68,902.58

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=9034