Closed
Bug 1394084
Opened 7 years ago
Closed 7 years ago
Remove "code" from jsprototype.h macros
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: emk, Assigned: emk)
Details
Attachments
(1 file)
C/C++ enum values will start at 0 increment automatically. There is no point in maintaining enum values by hand.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8901425 [details] Bug 1394084 - Remove "code" from jsprototype.h macros. https://reviewboard.mozilla.org/r/172910/#review178656 Ah, nice simplification. I suppose having explicit codes was useful when we had to explicitly bump XDR versions, but now that it's buildid-keyed, that isn't a concern.
Attachment #8901425 -
Flags: review?(luke) → review+
Pushed by VYV03354@nifty.ne.jp: https://hg.mozilla.org/integration/autoland/rev/c55df9a2d910 Remove "code" from jsprototype.h macros. r=luke
|
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c55df9a2d910
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•