Remove "code" from jsprototype.h macros

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: emk, Assigned: emk)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
C/C++ enum values will start at 0 increment automatically. There is no point in maintaining enum values by hand.
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8901425 [details]
Bug 1394084 - Remove "code" from jsprototype.h macros.

https://reviewboard.mozilla.org/r/172910/#review178656

Ah, nice simplification.  I suppose having explicit codes was useful when we had to explicitly bump XDR versions, but now that it's buildid-keyed, that isn't a concern.
Attachment #8901425 - Flags: review?(luke) → review+

Comment 4

a year ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/c55df9a2d910
Remove "code" from jsprototype.h macros. r=luke
https://hg.mozilla.org/mozilla-central/rev/c55df9a2d910
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.