Closed Bug 1394084 Opened 3 years ago Closed 3 years ago

Remove "code" from jsprototype.h macros

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: emk, Assigned: emk)

Details

Attachments

(1 file)

C/C++ enum values will start at 0 increment automatically. There is no point in maintaining enum values by hand.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment on attachment 8901425 [details]
Bug 1394084 - Remove "code" from jsprototype.h macros.

https://reviewboard.mozilla.org/r/172910/#review178656

Ah, nice simplification.  I suppose having explicit codes was useful when we had to explicitly bump XDR versions, but now that it's buildid-keyed, that isn't a concern.
Attachment #8901425 - Flags: review?(luke) → review+
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/c55df9a2d910
Remove "code" from jsprototype.h macros. r=luke
https://hg.mozilla.org/mozilla-central/rev/c55df9a2d910
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.