1394084 - Remove "code" from jsprototype.h macros

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Masatoshi Kimura [:emk]]

C/C++ enum values will start at 0 increment automatically. There is no point in maintaining enum values by hand.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1394084 - Remove "code" from jsprototype.h macros.

Review commit: https://reviewboard.mozilla.org/r/172910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172910/

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8901425 [details]
Bug 1394084 - Remove "code" from jsprototype.h macros.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172910/diff/1-2/

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 8901425 [details]
Bug 1394084 - Remove "code" from jsprototype.h macros.

https://reviewboard.mozilla.org/r/172910/#review178656

Ah, nice simplification.  I suppose having explicit codes was useful when we had to explicitly bump XDR versions, but now that it's buildid-keyed, that isn't a concern.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c55df9a2d910
Remove "code" from jsprototype.h macros. r=luke

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c55df9a2d910