Streamline nsElementTable.cpp

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
This patch does the following.

- Uses a macro to make gHTMLElements[] much more concise.

- Makes nsHTMLElement::mTagID a debug-only field, because it's only used in
  assertions.
(Assignee)

Comment 1

a year ago
Created attachment 8901660 [details] [diff] [review]
Streamline nsElementTable.cpp
Attachment #8901660 - Flags: review?(mrbkap)
(Assignee)

Comment 2

a year ago
Created attachment 8901666 [details] [diff] [review]
Streamline nsElementTable.cpp

Here's a version that compiles.
Attachment #8901666 - Flags: review?(mrbkap)
(Assignee)

Updated

a year ago
Attachment #8901660 - Attachment is obsolete: true
Attachment #8901660 - Flags: review?(mrbkap)
Comment on attachment 8901666 [details] [diff] [review]
Streamline nsElementTable.cpp

Review of attachment 8901666 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: parser/htmlparser/nsElementTable.h
@@ +86,5 @@
>    int             mParentBits;        //defines groups that can contain this element
>    bool            mLeaf;
>  
>    static  bool    IsContainer(eHTMLTags aTag);
>  }; 

Mind killing this trailing ws while you're here?
Attachment #8901666 - Flags: review?(mrbkap) → review+

Comment 4

a year ago
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9fa3fc0dca7
Streamline nsElementTable.cpp. r=mrbkap.
https://hg.mozilla.org/mozilla-central/rev/a9fa3fc0dca7
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.