Closed
Bug 1394300
Opened 8 years ago
Closed 8 years ago
Streamline nsElementTable.cpp
Categories
(Core :: DOM: HTML Parser, enhancement)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file, 1 obsolete file)
22.53 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
This patch does the following.
- Uses a macro to make gHTMLElements[] much more concise.
- Makes nsHTMLElement::mTagID a debug-only field, because it's only used in
assertions.
![]() |
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8901660 -
Flags: review?(mrbkap)
![]() |
Assignee | |
Comment 2•8 years ago
|
||
Here's a version that compiles.
Attachment #8901666 -
Flags: review?(mrbkap)
![]() |
Assignee | |
Updated•8 years ago
|
Attachment #8901660 -
Attachment is obsolete: true
Attachment #8901660 -
Flags: review?(mrbkap)
Comment 3•8 years ago
|
||
Comment on attachment 8901666 [details] [diff] [review]
Streamline nsElementTable.cpp
Review of attachment 8901666 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
::: parser/htmlparser/nsElementTable.h
@@ +86,5 @@
> int mParentBits; //defines groups that can contain this element
> bool mLeaf;
>
> static bool IsContainer(eHTMLTags aTag);
> };
Mind killing this trailing ws while you're here?
Attachment #8901666 -
Flags: review?(mrbkap) → review+
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9fa3fc0dca7
Streamline nsElementTable.cpp. r=mrbkap.
![]() |
||
Comment 5•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•