Closed Bug 1394300 Opened 4 years ago Closed 4 years ago

Streamline nsElementTable.cpp

Categories

(Core :: DOM: HTML Parser, enhancement)

Product:
Core
Component:
DOM: HTML Parser
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

Attachments

(1 file, 1 obsolete file)

Streamline nsElementTable.cpp
22.53 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review 
This patch does the following.

- Uses a macro to make gHTMLElements[] much more concise.

- Makes nsHTMLElement::mTagID a debug-only field, because it's only used in
  assertions.
Attached patch Streamline nsElementTable.cpp (obsolete) — — Splinter Review
Attachment #8901660 - Flags: review?(mrbkap)
Here's a version that compiles.
Attachment #8901666 - Flags: review?(mrbkap)
Attachment #8901660 - Attachment is obsolete: true
Attachment #8901660 - Flags: review?(mrbkap)
Comment on attachment 8901666 [details] [diff] [review]
Streamline nsElementTable.cpp

Review of attachment 8901666 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: parser/htmlparser/nsElementTable.h
@@ +86,5 @@
>    int             mParentBits;        //defines groups that can contain this element
>    bool            mLeaf;
>  
>    static  bool    IsContainer(eHTMLTags aTag);
>  }; 

Mind killing this trailing ws while you're here?
Attachment #8901666 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/a9fa3fc0dca7
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.