1394300 - Streamline nsElementTable.cpp

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement)

Description

[Nicholas Nethercote [:njn]]

This patch does the following.

- Uses a macro to make gHTMLElements[] much more concise.

- Makes nsHTMLElement::mTagID a debug-only field, because it's only used in
  assertions.

Comment 1

[Nicholas Nethercote [:njn]]

Attachment: Streamline nsElementTable.cpp

Comment 2

[Nicholas Nethercote [:njn]]

Attachment: Streamline nsElementTable.cpp

Here's a version that compiles.

Comment 3

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

Comment on attachment 8901666 [details] [diff] [review]
Streamline nsElementTable.cpp

Review of attachment 8901666 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: parser/htmlparser/nsElementTable.h
@@ +86,5 @@
>    int             mParentBits;        //defines groups that can contain this element
>    bool            mLeaf;
>  
>    static  bool    IsContainer(eHTMLTags aTag);
>  }; 

Mind killing this trailing ws while you're here?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9fa3fc0dca7
Streamline nsElementTable.cpp. r=mrbkap.

Comment 5

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a9fa3fc0dca7