1394341 - mismatched moz_xmalloc/delete in SharedBuffer/AudioBlock

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement, P3)

Description

[Karl Tomlinson (:karlt)]

The current global override of operator delete in mozalloc.h happens to be compatible with moz_xmalloc, but there is no need to depend on that.

Comment 1

[Karl Tomlinson (:karlt)]

http://eli.thegreenplace.net/2015/c-deleting-destructors-and-virtual-operator-delete/ gives a good description of operator delete with polymorphism.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: bug 1394341 replace xmalloc with operator new(size_t) to match AudioBlock deallocation in delete

Review commit: https://reviewboard.mozilla.org/r/176252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176252/

Comment 3

[Paul Adenot (:padenot)]

Comment on attachment 8904425 [details]
bug 1394341 replace xmalloc with operator new(size_t) to match AudioBlock deallocation in delete

https://reviewboard.mozilla.org/r/176252/#review181234

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57865ef80d4f
replace xmalloc with operator new(size_t) to match AudioBlock deallocation in delete r=padenot

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/57865ef80d4f