Closed Bug 1394341 Opened 3 years ago Closed 3 years ago

mismatched moz_xmalloc/delete in SharedBuffer/AudioBlock

Categories

(Core :: Web Audio, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(1 file)

The current global override of operator delete in mozalloc.h happens to be compatible with moz_xmalloc, but there is no need to depend on that.
http://eli.thegreenplace.net/2015/c-deleting-destructors-and-virtual-operator-delete/ gives a good description of operator delete with polymorphism.
Depends on: 1391482
Flags: in-testsuite-
Comment on attachment 8904425 [details]
bug 1394341 replace xmalloc with operator new(size_t) to match AudioBlock deallocation in delete

https://reviewboard.mozilla.org/r/176252/#review181234
Attachment #8904425 - Flags: review?(padenot) → review+
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57865ef80d4f
replace xmalloc with operator new(size_t) to match AudioBlock deallocation in delete r=padenot
https://hg.mozilla.org/mozilla-central/rev/57865ef80d4f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.