1394377 - Increase shutdown timeout for Marionette client from 65s to 120s

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

The currently used shutdown timeout is too short and as such (especially for debug builds) the background hang monitor is not able to kill Firefox due to a long hanging thread during shutdown.

As result we do not get any information why a shutdown has been taken that long. See bug 1385605 or others for example.

Given that the current shutdown hangs are all caused by sessionrestore tests, I would assume it's related to this component. Maybe its just bug 1387222 as I have seen on bug 1385605.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1394377 - Increase default shutdown timeout to 120s.

The background thread hang monitor will crash Firefox after 60s if
a shutdown is too slow. Debug builds are slower and as such Marionette
would force kill Firefox right before the hang monitor can kick in.

Review commit: https://reviewboard.mozilla.org/r/173294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173294/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8901865 [details]
Bug 1394377 - Increase default shutdown timeout to 120s.

https://reviewboard.mozilla.org/r/173294/#review179022

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f85951d982ab
Increase default shutdown timeout to 120s. r=maja_zf

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f85951d982ab

Comment 5

[David Burns :automatedtester]

Comment on attachment 8901865 [details]
Bug 1394377 - Increase default shutdown timeout to 120s.

https://reviewboard.mozilla.org/r/173294/#review179232

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

The change works like expected and we do no longer force kill Firefox before the background hang monitor kicks in. Lets uplift this test-only patch to beta too. Thanks.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d704dede3a8d