1394436 - In Settings, rename "Disconnect" to "Disconnect Sync"

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, enhancement, P2)

Description

[Ryan Feeley [:rfeeley]]

It has been observed that the Disconnect button (and the Sign Out that preceded it) lack a connection to Sync.

In the future we will likely give Sync its own preferences section like it has on Android, but in the meantime, we need two changes:

1. "Disconnect" should say "Disconnect Sync" to better connect it to Sync
2. This button should not delete local bookmarks. Deleting local data has nothing to do with Sync.

Comment 1

[Alex Davis [:adavis]]

As per the #2 in your list, there is a bug about it here: https://bugzilla.mozilla.org/show_bug.cgi?id=1392758

It may be a result of the way we integrated bi-directional bookmarks.

Comment 2

[Alex Davis [:adavis]]

:rfeeley also FWIW, so long as datadog is capturing logouts from iOS, there seems to be a very low volume of users disconnecting:
https://app.datadoghq.com/dash/346821/fxa---signout?live=true&page=0&is_auto=false&from_ts=1500940178682&to_ts=1503532178682&tile_size=m

I'm not good with Datadog. Maybe you're able to re-plot that chart to filter for only iOS users.

Comment 3

[Richard Newman [:rnewman]]

Signing out of Sync doesn't delete your local data. It just so happens that the hack we used for short-term bookmark upload makes all of your local bookmarks into _remote_ bookmarks, which _are_ temporary (because they're just waiting to be merged, right?), and so _are_ deleted when you sign out.

As Alex mentioned, #2 is thoroughly discussed in Bug 1392758, but I'd change his "may be" into "definitely is" :D

This will stop happening when we turn on proper bidirectional sync.

Morphing this bug to just be #1.

Comment 4

[Ryan Feeley [:rfeeley]]

Good news!

Yes, very few users are disconnecting on iOS.

Oddly there are a lot more doing so from desktop and Android Chrome.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Is this something we could get a new string for by v9.1? Right now, the "Disconnect" string has no context around it.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #5)
> Is this something we could get a new string for by v9.1? Right now, the
> "Disconnect" string has no context around it.

As far as I understand the release schedule for Firefox for iOS, v9.x comes from the strings we started localizing last week, so the sooner we expose it the better.

Still unclear to me if the hand off date changed, since we were a couple of weeks behind schedule with string extraction
https://wiki.mozilla.org/Firefox_for_iOS_Train_Schedule

Comment 7

[Vijay Budhram]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3255

Update to new strings. r?

Comment 8

[Vijay Budhram]

Merged to master!