1394469 - Push notification misbehave after sending a register for push from Leanplum

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: b06b848a9f7406
Device: iPhone 7
iOS: 10.3.3

Steps to reproduce:
1. Launch Firefox
2. Log in to FxA on desktop and iOS (after logging in you will be prompted to allow notification)
3. Tap [Allow] when prompt to allow notifications
4. Go to Leanplum messages and send a 'Register for Push' action (No message will be received as the permission for notification was previously allowed.)
5. Background the app on iOS by tapping on the Home button
6. Go to Firefox desktop and send a tab to your iOS device. 

Actual results: 
- After step 6) 'Tap to Begin' notifications is displayed. The tab will also be received after tapping on the 'Tap to Begin' notification, backgrounding the app and tapping on the correct notification.

Expected results:
- No 'Tap to begin' notification should be displayed, only the notification for the received tab should be displayed.

Comment 1

[:sdaswani]

This is interesting, but please note the test case is a little forced. Specifically, we would never do a Step 4, as on Leanplum we know which users have a push token, so we would never send the 'Register for Push' action to someone who has a push token.

So it may be something to look into but I don't think it should be a blocker.

Comment 2

[James Hugman [:jhugman] [@jhugman]]

It's not clear what is happening here: there is an intersection with Leanplum.

The message coming from autopush is not being decrypted.

Likely steps – very high level:

1. Sign in for FxA, and enter the push registration flow.
2. The WebPush key material is generated.
3. Key material is given to FxA.
4. LeanPlum asks for a APNS token, and we enter the push registration flow again.
5. The WebPush key material is generated again.
6. Now: FxA has incompatible Key material.

Comment 3

[:sdaswani]

I wonder if the intersection with LP is purely coincidental - if anyone (LP, native code, etc.) asked for an APNS token in step 4, would the incompatible key still result?

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3114

Comment 5

[James Hugman [:jhugman] [@jhugman]]

(In reply to Susheel Daswani from comment #3)
> I wonder if the intersection with LP is purely coincidental - if anyone (LP,
> native code, etc.) asked for an APNS token in step 4, would the incompatible
> key still result?

Yes, it's conceivable that Apple send us another APNS token without us asking for one.

Comment 6

[Farhan Patel [:farhan]]

https://github.com/mozilla-mobile/firefox-ios/commit/b2dd97aa1b49683fd5ec640c2ed79a264f3479c0

Comment 7

[Simon Basca [:SimonB]]

Verifying as fix on master 631c2932d3. The tab is sent correctly and the 'Tap to Begin' notification is no longer displayed.

Comment 8

[James Hugman [:jhugman] [@jhugman]]

Uplifted to v8.x.

Comment 9

[Farhan Patel [:farhan]]

uplifted to v9.x as well.

Comment 10

[Simon Basca [:SimonB]]

Verifying as fix on 8.3(5817).