1394510 - Write mochitests for pinch-zooming behaviour

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

We don't really have any mochitests that exercise the pinch-zoom code. We should write some. (This is inspired in part due to bug 1358771 comment 7).

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Here is a try push with the tests passing, but the patches aren't cleaned up in this one.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a60bbec720c4593edeb9f0590be9d2abbf2daa43

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Latest version: https://treeherder.mozilla.org/#/jobs?repo=try&revision=219551ef01440e0a85da1c5059af745ea92188d4

Seems like one of the tests is still failing intermittently. I'll put up the one that seems to work fine and continue poking at the other one.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1394510 - Fix GeckoLayerClient touch generation code.

Review commit: https://reviewboard.mozilla.org/r/173824/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173824/

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1394510 - Extract a helper method to generate more generic touch sequences.

Review commit: https://reviewboard.mozilla.org/r/173826/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173826/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1394510 - Add a basic pinch-zoom test.

Review commit: https://reviewboard.mozilla.org/r/173828/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173828/

Comment 7

[Botond Ballo [:botond]]

Comment on attachment 8902302 [details]
Bug 1394510 - Fix GeckoLayerClient touch generation code.

https://reviewboard.mozilla.org/r/173824/#review179260

Comment 8

[Botond Ballo [:botond]]

Comment on attachment 8902303 [details]
Bug 1394510 - Extract a helper method to generate more generic touch sequences.

https://reviewboard.mozilla.org/r/173826/#review179270

::: gfx/layers/apz/test/mochitest/apz_test_native_event_utils.js:250
(Diff revision 1)
> +  // The last synthesizeNativeTouch call will be the TOUCH_REMOVE which happens
> +  // one iteration of aPosition after the last non-null value.
> +  var lastSynthesizeCall = lastNonNullValue + aTouchIds.length;
> +
> +  // track which touches are down and which are up. start with all up
> +  var touchIsDown = new Array(aTouchIds.length);

Since the array stores points, not booleans, I'd call it something like |currentPositions|.

::: gfx/layers/apz/test/mochitest/apz_test_native_event_utils.js:308
(Diff revision 1)
> +  var continuation = synthesizeNativeTouchSequences(aElement, positions, aObserver, [aTouchId]);
> +  var yielded = continuation.next();
> +  while (!yielded.done) {
> +    yielded = continuation.next();
>    }
> -  synthesizeNativeTouch(aElement, aX + aDeltaX, aY + aDeltaY, SpecialPowers.DOMWindowUtils.TOUCH_CONTACT, null, aTouchId);
> +  return yielded.value;

This will just always be |true|?

Comment 9

[Botond Ballo [:botond]]

Comment on attachment 8902304 [details]
Bug 1394510 - Add a basic pinch-zoom test.

https://reviewboard.mozilla.org/r/173828/#review179290

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8902303 [details]
Bug 1394510 - Extract a helper method to generate more generic touch sequences.

https://reviewboard.mozilla.org/r/173826/#review179270

> Since the array stores points, not booleans, I'd call it something like |currentPositions|.

Updated. Name was left over from a previous version when I was just using booleans :)

> This will just always be |true|?

Yeah. But we might want to add other return possibilities from synthesizeNativeTouchSequences in the future.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8902302 [details]
Bug 1394510 - Fix GeckoLayerClient touch generation code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/173824/diff/1-2/

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8902303 [details]
Bug 1394510 - Extract a helper method to generate more generic touch sequences.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/173826/diff/1-2/

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8902304 [details]
Bug 1394510 - Add a basic pinch-zoom test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/173828/diff/1-2/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df848e39eddd
Fix GeckoLayerClient touch generation code. r=botond
https://hg.mozilla.org/integration/autoland/rev/4f13998e509f
Extract a helper method to generate more generic touch sequences. r=botond
https://hg.mozilla.org/integration/autoland/rev/cc4bc228547e
Add a basic pinch-zoom test. r=botond

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/df848e39eddd
https://hg.mozilla.org/mozilla-central/rev/4f13998e509f
https://hg.mozilla.org/mozilla-central/rev/cc4bc228547e