1394558 - Permafailing dom/animation/test/crashtests/1272475-2.html | application crashed [@ nsCSSValue::GetFloatValue]

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: aiakab [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=126532404&repo=autoland

https://queue.taskcluster.net/v1/task/HJ2Da_OuTJ6EAKkEkiH5Qg/runs/0/artifacts/public/logs/live_backing.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/HJ2Da_OuTJ6EAKkEkiH5Qg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

https://treeherder.mozilla.org/logviewer.html#?job_id=126532404&repo=autoland&lineNumber=2596
https://public-artifacts.taskcluster.net/HJ2Da_OuTJ6EAKkEkiH5Qg/0/public/logs/live_backing.log

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This started failing with https://github.com/servo/servo/pull/18239 and did not get fixed by https://github.com/servo/servo/pull/18287

Comment 2

[Emilio Cobos Álvarez (:emilio)]

So I see why this happens, and it's because https://github.com/servo/servo/pull/18239/files#diff-3c5f6a072f9431c75cbb2246efa3b1daR71 changed the animation:

    (&Angle::Radians(ref this), &Angle::Radians(ref other))

From looking like:

    Angle::from_radians(this.animate(other, procedure)?)

To look like:

    Angle::Radians(this.animate(other, procedure)?)

Which doesn't clamp and thus fails the test-case.

The previous behaviour is a one-off, really, and rather obscure. If you replace `rad` for `turn` in the test-case, you should get the assertion on debug builds without that patch.

Anyway... Anthony, the best idea I have is to ensure f32::animate does never return NaN (at least if both the inputs are NaN?), wdyt?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(Keeping ni? just in case)

Comment 4

[Emilio Cobos Álvarez (:emilio)]

https://github.com/servo/servo/pull/18292

Comment 5

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=126717719

Crashtests are green now.

Comment 6

[Intermittent Failures Robot]

13 failures in 939 pushes (0.014 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 13

Platform breakdown:
* linux64-stylo-sequential: 5
* linux64-stylo: 3
* linux32-stylo: 2
* windows7-32-stylo: 1
* windows10-64-stylo: 1
* macosx64-stylo: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1394558&startday=2017-08-28&endday=2017-09-03&tree=all