1394583 - Remove default properties from nsIHTMLEditor

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Nicholas Nethercote [inactive]]

masayuki, I'm not sure if this is a reasonable thing to do, but a try server
push works fine!

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove default properties from nsIHTMLEditor

nsIHTMLEditor's addDefaultProperty(), removeDefaultProperty(),
removeAllDefaultProperties() methods are never used -- not from C++ code or
script, in either mozilla-central or comm-central.

So this patch removes them. This means that HMLTEditor::mDefaultStyles is never
used, so the patch removes it and all the code that manipulates it as well.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Sure. Also, they are not used by BlueGriffon <https://github.com/therealglazou/bluegriffon/tree/bg2> too.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8902004 [details] [diff] [review]
Remove default properties from nsIHTMLEditor

Really nice!

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d8fdaa9efc827fa1bf532ce6c92fbb6b39b5e28
Bug 1394583 - Remove default properties from nsIHTMLEditor. r=masayuki.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5d8fdaa9efc8