Closed
Bug 1394583
Opened 8 years ago
Closed 8 years ago
Remove default properties from nsIHTMLEditor
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
16.32 KB,
patch
|
masayuki
:
review+
|
Details | Diff | Splinter Review |
masayuki, I'm not sure if this is a reasonable thing to do, but a try server
push works fine!
|
Assignee | |
Comment 1•8 years ago
|
||
nsIHTMLEditor's addDefaultProperty(), removeDefaultProperty(),
removeAllDefaultProperties() methods are never used -- not from C++ code or
script, in either mozilla-central or comm-central.
So this patch removes them. This means that HMLTEditor::mDefaultStyles is never
used, so the patch removes it and all the code that manipulates it as well.
Attachment #8902004 -
Flags: review?(masayuki)
|
||
Comment 2•8 years ago
|
||
Sure. Also, they are not used by BlueGriffon <https://github.com/therealglazou/bluegriffon/tree/bg2> too.
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8902004 [details] [diff] [review]
Remove default properties from nsIHTMLEditor
Really nice!
Attachment #8902004 -
Flags: review?(masayuki) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d8fdaa9efc827fa1bf532ce6c92fbb6b39b5e28
Bug 1394583 - Remove default properties from nsIHTMLEditor. r=masayuki.
|
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
|
||
Updated•5 years ago
|
Blocks: redesign-editor-scriptable-API
You need to log in
before you can comment on or make changes to this bug.
Description
•