1394631 - Assertion failure: contentsReflowStatus.IsComplete() (We gave button-contents frame unconstrained available height, so it should be complete)

Status: NEW

(Core :: Layout: Form Controls, defect, P3)

Description

[Jason Kratzer [:jkratzer]]

Attachment: trigger.html

Testcase found while fuzzing mozilla-central rev 20170828-d10c97627b51.

Assertion failure: contentsReflowStatus.IsComplete() (We gave button-contents frame unconstrained available height, so it should be complete), at /home/worker/workspace/build/src/layout/forms/nsHTMLButtonControlFrame.cpp:256
#01: nsHTMLButtonControlFrame::Reflow at layout/forms/nsHTMLButtonControlFrame.cpp:205
#02: nsLineLayout::ReflowFrame at layout/generic/nsLineLayout.cpp:921
#03: nsBlockFrame::ReflowInlineFrame at layout/generic/nsBlockFrame.cpp:4220
#04: nsBlockFrame::DoReflowInlineFrames at layout/generic/nsBlockFrame.cpp:4015
#05: nsBlockFrame::ReflowInlineFrames at layout/generic/nsBlockFrame.cpp:3892
#06: nsBlockFrame::ReflowLine at layout/generic/nsBlockFrame.cpp:2874
#07: nsBlockFrame::ReflowDirtyLines at layout/generic/nsBlockFrame.cpp:2407
#08: nsBlockFrame::Reflow at layout/generic/nsBlockFrame.cpp:1246
#09: nsContainerFrame::ReflowChild at layout/generic/nsContainerFrame.cpp:937
#10: nsColumnSetFrame::ReflowChildren at layout/generic/nsIFrame.h:294
#11: nsColumnSetFrame::ReflowColumns at layout/generic/nsColumnSetFrame.cpp:508
#12: nsColumnSetFrame::Reflow at layout/generic/nsColumnSetFrame.cpp:1250
#13: nsBlockReflowContext::ReflowBlock at layout/generic/nsBlockReflowContext.cpp:307
#14: nsBlockFrame::ReflowBlockFrame at layout/generic/nsBlockFrame.cpp:3527
#15: nsBlockFrame::ReflowLine at layout/generic/nsBlockFrame.cpp:2868
#16: nsBlockFrame::ReflowDirtyLines at layout/generic/nsBlockFrame.cpp:2407
#17: nsBlockFrame::Reflow at layout/generic/nsBlockFrame.cpp:1246
#18: nsContainerFrame::ReflowChild at layout/generic/nsContainerFrame.cpp:937
#19: nsColumnSetFrame::ReflowChildren at layout/generic/nsIFrame.h:294
#20: nsColumnSetFrame::ReflowColumns at layout/generic/nsColumnSetFrame.cpp:508
#21: nsColumnSetFrame::Reflow at layout/generic/nsColumnSetFrame.cpp:1250
#22: nsContainerFrame::ReflowChild at layout/generic/nsContainerFrame.cpp:937
#23: nsCanvasFrame::Reflow at layout/generic/nsCanvasFrame.cpp:758
#24: nsContainerFrame::ReflowChild at layout/generic/nsContainerFrame.cpp:937
#25: nsHTMLScrollFrame::ReflowScrolledFrame at layout/generic/nsGfxScrollFrame.cpp:553
#26: nsHTMLScrollFrame::ReflowContents at layout/generic/nsGfxScrollFrame.cpp:691
#27: nsHTMLScrollFrame::Reflow at layout/generic/nsGfxScrollFrame.cpp:1039
#28: nsContainerFrame::ReflowChild at layout/generic/nsContainerFrame.cpp:980

Comment 1

[Ryan VanderMeulen [:RyanVM]]

INFO: Last good revision: ffb38910dcae79a05680bdb917ef93e69d6d3a8a
INFO: First bad revision: 1e3af7fd9bfe507cdcff5e05a95c3a763617f25c
INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ffb38910dcae79a05680bdb917ef93e69d6d3a8a&tochange=1e3af7fd9bfe507cdcff5e05a95c3a763617f25c

Bug 984869 seems like the likely candidate in that range given the button use in the testcase. Note that in order to reproduce on builds predating bug 1300895, you need to change the testcase from "columns" to "-moz-columns".

Comment 2

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals