139466 - Copy and Paste in Composer can generate invalid markup

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

1. launch Composer
2. type some chars
3. select "Header 1" from pulldown format menu
4. Select all
5. Copy
6. Paste 3 times

Expected result : three identical H1 elements, all children of BODY
Result          : three **nested** H1

This is very invalid markup and serious end-user problem.
Tested with

Comment 1

[rossi]

confirming with 2002042209
when pasting into a new line it works as it should... don't know if it's invalid
markup, but it definitely isn't the expected result. (and it works for other
things like <a>)

Comment 2

[Joe Francis]

our dtd must be telling us it's ok to put an h1 in an h1.  If thats wrong this
is an easy fix.  If thats right then this isn't a bug at all.

Comment 3

[Joe Francis]

checking the spec shows that this is indeed wrong.

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

*** Bug 142602 has been marked as a duplicate of this bug. ***

Comment 5

[michael wendell]

I am still seeing this problem with the 05-09 trunk build.

Following original steps, I am still getting nested H1 tags.

I am reopening this bug.

Comment 6

[Joe Francis]

hmm.  I believe I marked it fixed by accident to start with.  The comment I made
at the time acknowledges it is a real bug.

Comment 7

[sujay]

nominating.

Comment 8

[Joe Francis]

Attachment: patch to COtherElement.h

As I suspected this was a dtd issue.  I altered the strict dtd to prevent
headings from containing other headings.

Comment 9

[Joe Francis]

need r and sr

Comment 10

[Kathleen :Brade]

cc harishd to review
cc jst to super-review

Comment 11

[harishd]

Comment on attachment 85994 [details] [diff] [review]
patch to COtherElement.h

add space around '='. With that r=harishd

Comment 12

[Joe Francis]

I will gladly put spaces around the "=" (which I prefer as well) but you may want 
to not that the rest of the file is filled with the opposite style.  :-)

Comment 13

[Johnny Stenback (:jst)]

Comment on attachment 85994 [details] [diff] [review]
patch to COtherElement.h

sr=jst

Comment 14

[harishd]

Joe: The author of the code is not with netscape anymore and when the code was
written coding conventions weren't followed strictly :-/

Comment 15

[Joe Francis]

fix landed on trunk

Comment 16

[Jaime Rodriguez, Jr.]

shrir - can you pls verify this fixed on the trunk? thanks!

Comment 17

[Kevin McCluskey (gone)]

Removing nsbeta1+, adt1.0.1, mozilla1.0.1. The fix is too risky for the 1.0 branch.

Comment 18

[sairuh (rarely reading bugmail)]

vrfy'd fixed on win2k and linux rh8.0 (2003.03.03.05) and mac 10.2.4
(2003.02.28.10) with comm trunk bits.