Closed Bug 1394680 Opened 7 years ago Closed 7 years ago

The Reload/Stop animation is inconsistent in dark lightweight themes

Categories

(Firefox :: Theme, defect, P1)

57 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.3 - Sep 19
Tracking Status
firefox57 --- fixed

People

(Reporter: petcuandrei, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-animation])

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170828100127

Steps to reproduce:

Installed a dark theme from AMO (for example this one) https://addons.mozilla.org/en-US/firefox/addon/science-theme-by-m-donna/

Go to any page and reload the page


Actual results:

The reload button changed from white to dark and back again. The same with the little dot on the tab bar.


Expected results:

Both the Reload/Stop button animation and the tab dot animation should have stayed white.
Component: Untriaged → Theme
The same thing happens with the builtin dark theme.
Confirmed and reproducible.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
This bug still happens with the latest build from 2017-09-04 even if it's "duplicate" #1392793 was fixed.

Maybe this is a different issue. I will reopen.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Ah, bug 1392793 only fixed this for the dark compact theme.
Summary: The Reload/Stop animation is inconsistent in dark themes → The Reload/Stop animation is inconsistent in dark lightweight themes
Whiteboard: [photon-visual][triage]
Whiteboard: [photon-visual][triage] → [photon-animation][triage]
Assignee: nobody → jaws
Status: REOPENED → ASSIGNED
Whiteboard: [photon-animation][triage] → [photon-animation]
Iteration: --- → 57.3 - Sep 19
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [photon-animation] → [reserve-photon-animation]
Comment on attachment 8905392 [details]
Bug 1394680 - Apply the white fill color to animatable boxes inside of toolbars that have bright text. We were already doing this for compact themes but missed doing it for lightweight themes.

https://reviewboard.mozilla.org/r/177178/#review182216
Attachment #8905392 - Flags: review?(ntim.bugs) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f4f3fa12161
Apply the white fill color to animatable boxes inside of toolbars that have bright text. We were already doing this for compact themes but missed doing it for lightweight themes. r=ntim
https://hg.mozilla.org/mozilla-central/rev/3f4f3fa12161
Status: ASSIGNED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
The little bouncing dot still changes color. I don't think that is normal. Am I wrong?

Sorry for reopening but I mentioned in the initial description anyway. If you wish we can close this one and open a new ticket for the bouncing dot.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hello Andrei.  I've put a 'needinfo' for Jared to take a look.  Going to keep the bug as Resolved - if it is an issue a follow up bug will be filed and triaged by the team.  Thanks.
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Flags: needinfo?(jaws)
Resolution: --- → FIXED
(In reply to andrei from comment #10)
> The little bouncing dot still changes color. I don't think that is normal.
> Am I wrong?
> 
> Sorry for reopening but I mentioned in the initial description anyway. If
> you wish we can close this one and open a new ticket for the bouncing dot.

Hi Andrei, can you do a screen recording or take a screenshot of the issue you are seeing?
Flags: needinfo?(jaws) → needinfo?(andrei)
What's probably bothering Andrei is the fact that the little dot turns dark blue with the dark lightweight theme.

If that is the issue, I'm pretty sure there's already a bug filed about it.
(In reply to Tim Nguyen :ntim from comment #13)
> If that is the issue, I'm pretty sure there's already a bug filed about it.

I guess this is bug 1396062, but for lightweight themes ?
I have reproduced this bug with Nightly 57.0a1 (2017-08-28) on Windows 8.1, 64-Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20170909100226
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday-20170906]
Status: RESOLVED → VERIFIED
Flags: qe-verify?
Thank you! I will track that bug.
Flags: needinfo?(andrei)
This is the theme I am using https://addons.mozilla.org/en-US/firefox/addon/blue-mozilla-firefox/ and this is the video of the dot switching from white to blue. https://vimeo.com/233216981
You need to log in before you can comment on or make changes to this bug.