1394693 - GeckoScreenOrientation.(PORTRAIT|LANDSCAPE) should map to ActivityInfo.SCREEN_ORIENTATION_SENSOR_(PORTRAIT|LANDSCAPE).

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, enhancement)

Description

[John Lin [:jhlin][:jolin]]

Because PORTRAIT = PORTRAIT_PRIMARY | PORTRAIT_SECONDARY and LANDSCAPE = LANDSCAPE_PRIMARY | LANDSCAPE_SECONDARY, when orientation is locked to these 2 types, user should be able to rotate the screen 180 degree if the mobile device's sensor supports it.

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1394693 - return more appropriate screen orientation types.

Allow sensor to change which direction the screen is facing when using 'portrait' or 'landscape' to lock screen orientation.

Review commit: https://reviewboard.mozilla.org/r/173554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173554/

Comment 2

[Eugen Sawin [:esawin]]

Comment on attachment 8902110 [details]
Bug 1394693 - return more appropriate screen orientation types.

https://reviewboard.mozilla.org/r/173554/#review179040

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cc985da769f
return more appropriate screen orientation types. r=esawin

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7cc985da769f