1394746 - Many of the preferences sub-dialogs still come with a "Help" button pointing to old structure SUMO documents

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

STR:

1. Go to Preferences, scroll all the way down and click [Settings...] on the Network Proxy section, for example.
2. Click on the [Help] button

Expected:

1. Open a SUMO document that doesn't talk about "Advanced" panel, which we've removed.

Actual:

1. Opens https://support.mozilla.org/en-US/kb/advanced-panel-settings-in-firefox?redirectlocale=en-US&as=u&redirectslug=Options+window+-+Advanced+panel&utm_source=inproduct#connection_settings

There is also a problem where the hash doesn't actually matches the title, so the page didn't scroll to the right place.

[Tracking Requested - why for this release]: regression on 56 shipping feature.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Tina, I don't see invision has any mocks on sub-dialogs. Do we want to keep these buttons?

Cindy, is this already under SUMO team's radar? Are they supposed to fix the link on their side so this is not really a bug on ourside?

Thanks.

Comment 2

[Tina Hsieh[:Tina_Hsieh] UX]

I'd like to remove those help buttons, but it'll be good if we can get some telemetry data to support this decision. :)

Comment 3

[Gerry Chang [:gchang]]

Track 56- as this is not a bug on our side.

Comment 4

[chsiang]

We checked the data of people who clicked on the help question mark to access SUMO before and it was really low. I think it's safe to say the help button under a sub-category will be even less frequently used. For that reason, I feel pretty comfortable getting rid off that help button.
I just sent an email to Joni to check their plan. When it's updated, we can update our redirect tied to the question mark. That should be sufficient "help" for users.

Comment 5

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Looping in SUMO.

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Unassigned myself since it's still too early to start implementing without hearing decision from SUMO.

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Emma, do you know anyone else we can ask? rmcguigan has been ni for a while but we didn't get any respond. Thanks

Comment 8

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Asking guigs directly.

Comment 9

[guigs [:guigs] PST (please needinfo me!)]

Hi Joni, this is another in product link that is pointing to old information. The Network proxy link now is in the General section at the bottom in preferences. 

This article has great info, just not current screenshots. I will also add this bug to the article discussion thread.

Comment 10

[Alice Wyman]

(In reply to guigs [guigs] PST (please needinfo me!) from comment #9)
> Hi Joni, this is another in product link that is pointing to old
> information. The Network proxy link now is in the General section at the
> bottom in preferences. 
> 
> This article has great info, just not current screenshots. I will also add
> this bug to the article discussion thread.

Article discussion thread: https://support.mozilla.org/en-US/kb/advanced-panel-settings-in-firefox/discuss/7204

We could create a new SUMO KB article that covers the "Connection settings Dialog" information that's currently included in https://support.mozilla.org/en-US/kb/advanced-panel-settings-in-firefox#w_connection-settings-dialog if that information is valuable but I'll leave that up to Joni.

Comment 11

[Alice Wyman]

In the Firefox 56 General panel Language and Appearance section, the Advanced, Colors and Choose buttons all open dialogs with a Help button that links to the https://support.mozilla.org/en-US/kb/settings-for-web-content-pop-ups-fonts-languages SUMO KB article(Redirected from Options window - Content panel). For example, the Advanced button opens a Fonts dialog with a Help button that links to https://support.mozilla.org/en-US/kb/settings-for-web-content-pop-ups-fonts-languages?redirectlocale=en-US&as=u&redirectslug=Options+window+-+Content+panel&utm_source=inproduct#fonts_and_colors

I posted a thread about that issue to the Content panel article's discussion forum:
https://support.mozilla.org/en-US/kb/settings-for-web-content-pop-ups-fonts-languages/discuss/7207

Comment 12

[Ricky Chien [:rickychien] (inactive)]

(In reply to Alice Wyman from comment #11)
> For example, the Advanced button opens a Fonts dialog with a Help button
> that links to
> https://support.mozilla.org/en-US/kb/settings-for-web-content-pop-ups-fonts-
> languages?redirectlocale=en-US&as=u&redirectslug=Options+window+-
> +Content+panel&utm_source=inproduct#fonts_and_colors

Click on your link cannot redirect to the right portion of "Font & Color" section. The hash has changed, so it should be

https://support.mozilla.org/en-US/kb/settings-for-web-content-pop-ups-fonts-languages?redirectlocale=en-US&as=u&redirectslug=Options+window+-+Content+panel&utm_source=inproduct#w_fonts-colors

Alice, I'd like to know is it possible that we can fix the wrong SUMO url from website but not to touch the Firefox codebase?

Comment 13

[Alice Wyman]

(In reply to Ricky Chien [:rickychien] from comment #12)
> Alice, I'd like to know is it possible that we can fix the wrong SUMO url
> from website but not to touch the Firefox codebase?

I tried editing the https://support.mozilla.org/en-US/kb/settings-for-web-content-pop-ups-fonts-languages article to change the  "Fonts & Colors" (#w_fonts-colors) section to "Fonts and Colors" (#w_fonts-and-colors) but it didn't help so I reverted that edit. I should have known it wouldn't work because the "Choose" button next to "Language" opens a Languages sub-dialog with a Help button that links to https://support.mozilla.org/en-US/kb/settings-for-web-content-pop-ups-fonts-languages?redirectlocale=en-US&as=u&redirectslug=Options+window+-+Content+panel&utm_source=inproduct#languages ... which should take you to https://support.mozilla.org/en-US/kb/settings-for-web-content-pop-ups-fonts-languages#w_languages but it doesn't.

Maybe Joni can figure something out?  

If you plan on changing the in-product links, you should know that most of the "Fonts & Colors" section content was recently moved to another article.  The  https://support.mozilla.org/en-US/kb/settings-for-web-content-pop-ups-fonts-languages article  now says,  "For more information about settings for fonts and colors, see Change the fonts and colors websites use." with a link to https://support.mozilla.org/en-US/kb/change-fonts-and-colors-websites-use.  

If you want to keep Help links in the "Fonts & Colors" sub-dialogs and Joni can't fix it, I think the in-product links should be changed so that they go to the https://support.mozilla.org/en-US/kb/change-fonts-and-colors-websites-use article. As for the  Help button link in the Languages sub-dialog, maybe a new article is needed for that link (I'll leave it up to Joni).

Comment 14

[Ricky Chien [:rickychien] (inactive)]

I do believe the link

https://support.mozilla.org/en-US/kb/settings-for-web-content-pop-ups-fonts-languages?redirectlocale=en-US&as=u&redirectslug=Options+window+-+Content+panel&utm_source=inproduct#w_fonts-colors

of the Fonts & Colors sub-dialog help button is what we need, it's unnecessary to change it.

Alice, could you help me needinfo Joni? It would be better if he can help us fix the link.

e.g. We need to modify the url hash from #w_fonts-colors to #fonts_and_colors for Fonts & Colors help button...and so on.

Comment 15

[Ricky Chien [:rickychien] (inactive)]

Ah, Joni has been ni in Comment 9, let's wait for his reply.

Comment 16

[Joni Chan]

Thanks for looping me in.

Ricky, I've corrected the link for the Fonts & Colors button so it take users directly to the Fonts & Colors section in the article.

I've also replaced the link in comment #9 with a new article, per Alice's suggestion, and we'll work on editing that article as we do all the version 57 articles starting next week.

We're going to break up the Advanced preferences article into smaller articles and change them on our end so the in-product URLs redirect to the right place.

Comment 17

[Alice Wyman]

(from comment #13) 
> <snip> the "Choose" button
> next to "Language" opens a Languages sub-dialog with a Help button <snip> which should take you to
> https://support.mozilla.org/en-US/kb/settings-for-web-content-pop-ups-fonts-languages#w_languages 
> but it doesn't.

(In reply to Joni Savage ("need info" me) from comment #16)
> Ricky, I've corrected the link for the Fonts & Colors button so it take
> users directly to the Fonts & Colors section in the article.

Joni, can you also fix the Help link in the Languages sub-dialog so that it goes to the Languages section?

Comment 18

[Ricky Chien [:rickychien] (inactive)]

Thanks for your help Joni :)

I've checked all help buttons in Preferences sub-dialogs. As far as I can see, Help link in the Languages sub-dialog is unable to redirect to the correct Languages section as Alice mentioned on comment 17. After Languages link fixed, all help links of preferences would be correct.

Comment 19

[Joni Chan]

Hi, Ricky and Alice.

I've fixed the link. Please take a look and close the bug if it's working.

Comment 20

[Ricky Chien [:rickychien] (inactive)]

Good! Help links are correct now. Thanks for your help!

Comment 21

[Hani Yacoub, Desktop QA]

I verified this bug on Firefox Nightly 58.0a1 and on Firefox Beta 57.0b7 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64 and once I click on "Help" button I get redirected to a new Window to this line "https://support.mozilla.org/en-US/kb/connection-settings-firefox?as=u&utm_source=inproduct".

After I red all the comments above I still can't figure out if that was the desirable result.

Do you consider that I should cover other areas here and if I should verify all the "Help" button in preferences?

Comment 22

[Ricky Chien [:rickychien] (inactive)]

Thanks for bringing this question. I've removed qe-verify+ flag since this issue should be a SUMO website regression and there is no in-product changes. I've verified that these SUMO site links are able to redirect properly, and this fix will apply to all Firefox versions including release, beta & nightly.

Comment 23

[guigs [:guigs] PST (please needinfo me!)]

Please see - https://support.mozilla.org/en-US/kb/firefox-options-preferences-and-settings/discuss/7411

For suggestions to change what article it links to.

Comment 24

[Alice Wyman]

See https://support.mozilla.org/en-US/kb/firefox-options-preferences-and-settings/discuss/7411#post-16097 on why this bug was reopened.