1394792 - stylo: Add gtest microbenchmark for Servo_DeclarationBlock_GetPropertyValueById

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P5)

Comment 1

[Simon Sapin (:SimonSapin)]

Attachment: Bug 1394792 - Add gtest microbenchmark for Servo_DeclarationBlock_GetPropertyValueById.

Review commit: https://reviewboard.mozilla.org/r/173774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173774/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8902244 [details]
Bug 1394792 - Add gtest microbenchmark for Servo_DeclarationBlock_GetPropertyValueById.

https://reviewboard.mozilla.org/r/173774/#review179046

::: layout/style/test/gtest/StyloParsingBench.cpp:115
(Diff revision 1)
> +    nullptr
> +  );
> +
> +  for (int i = 0; i < GETPROPERTY_REPETITIONS; i++) {
> +    DOMString value_;
> +    nsAString& value = value_;

I guess this is done to make it more similar to the DOM profile, right?

Otherwise we can use `nsAutoString` or something like that.

::: layout/style/test/gtest/StyloParsingBench.cpp:120
(Diff revision 1)
> +    nsAString& value = value_;
> +    Servo_DeclarationBlock_GetPropertyValueById(
> +      block,
> +      eCSSProperty_width,
> +      &value
> +    );

`MOZ_ASSERT(value.EqualsLiteral("10px"))`? (not sure if worth)

Comment 3

[Simon Sapin (:SimonSapin)]

Comment on attachment 8902244 [details]
Bug 1394792 - Add gtest microbenchmark for Servo_DeclarationBlock_GetPropertyValueById.

https://reviewboard.mozilla.org/r/173774/#review179046

> I guess this is done to make it more similar to the DOM profile, right?
> 
> Otherwise we can use `nsAutoString` or something like that.

It’s rather the first thing I found when looking up callers to get something to compile at all, but yeah that too.

Comment 4

[Simon Sapin (:SimonSapin)]

Comment on attachment 8902244 [details]
Bug 1394792 - Add gtest microbenchmark for Servo_DeclarationBlock_GetPropertyValueById.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/173774/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0039e9a1276
Add gtest microbenchmark for Servo_DeclarationBlock_GetPropertyValueById. r=emilio

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f0039e9a1276