1394806 - High memory usage when WebRender is enabled

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P3)

Description

[Keith Hizal]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170829100404

Steps to reproduce:

I am using build 20170829100404 on openSUSE Tumbleweed on a Radeon RX 460.

I enabled webrender, webrenderest, layers-free, blob images, and forced hardware acceleration.
I've also enabled out of procces web extensions.


Actual results:

All texture caches and image templates, no matter what site is visited, are never used and remain at zero megabytes. Firefox's memory usage constantly increases, especially on pages with a lot of images such as deviantART or danbooru, until the system locks up.


Expected results:

The texture cache and image templates should be used. Firefox's memory usage should not reach 3 GBs, epecially when only 5 tabs are opened at one time, nor should it lock up the system.

Comment 1

[Keith Hizal]

To be more specific, when I said all caches, I meant all Webrender caches. File system cahce and memory cache seem to be working fine to my knowlege.

Comment 2

[Darkspirit]

comment 0 is from https://mozillagfx.wordpress.com/2017/08/28/webrender-newsletter-3/#comment-1420

(Keith Hizal from comment #0)
[...] until the system locks up.

This part might be bug 1377120.

Comment 3

[Keith Hizal]

I tested this on an Intel 5200U using HD Graphics and just like before, the texture templates and webrender caches are not used and the memory usage increases with every page loaded, especially ones with images.
I have not had a system lockup just yet though.

Comment 4

[Keith Hizal]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #2)
> comment 0 is from
> https://mozillagfx.wordpress.com/2017/08/28/webrender-newsletter-3/#comment-
> 1420
> 
> (Keith Hizal from comment #0)
> [...] until the system locks up.
> 
> This part might be bug 1377120.

I don't think it's that. I recently downloaded a file while Webrender was enabled. The only two windows open were the downloads window and a blank tab page. Firefox's memory usage climed continously untill it reached over 4 GBs. It dropped down to 2.7 after I closed the downloads window.

Comment 5

[Nicolas Silva [:nical]]

The texture cache counters in webrender's debugging HUD weren't updated after a refactoring of the texture cache, so they stayed equal to zero even though webrender was in fact using the texture cache. This has been fixed and the fix is in nightly.

Comment 6

[Keith Hizal]

One thing I've noticed is that enabling layers.gpu-process.enabled significantly reduces the RAM used by the main FireFox process. 
Of course, on Linux, bug 1401634 prevents this from reliably working.

Comment 7

[Asif Youssuff]

Attachment: memory-report.json.gz

I am also running WebRender on a machine with 8GB of RAM (going to upgrade, but wanted to test with 8 before an upgrade) and am running into situations where Firefox begins to swap, causing the entire machine to slow down. 

Attached a memory report after minimizing 3x in about:memory. 

Hope this helps. It's not a "test" profile, it is what I use day to day.

Comment 8

[lilydjwg]

I see significant memory usage raise when I have enabled WebRender too. My Firefox eats up >4G memory very soon (in less than one day), and yesterday on another machine it has triggered the OOM killer twice.

I'm using Arch Linux with current nightly.

Comment 9

[Sotaro Ikeda [:sotaro]]

Bug 1432708 is one bug that cause the memory leak.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

We've fixed a number of memory leaks since this bug was filed. Do you still see this issue?

Comment 11

[Keith Hizal]

It's much better than before.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Thanks. Closing this bug, but feel free to reopen or file a new bug if there are sites/usage patterns that result in abnormally bad memory usage.