1394834 - alembic in docker environment is configured wrong

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

The docker/config/alembic.ini file has this sqlalchemy.url:

sqlalchemy.url = postgresql://postgres:aPassword@postgresql:5432/socorro_migration_test

This setting is good for running the tests ("make dockertest"), but isn't good for testing migrations by hand. The database needs to be "breakpad".

When we run setup_app, it overrides that setting with "normal user pg" value. We should set docker/config/alembic.ini to use that value and adjust "make dockertest" to use the appropriate value for migration testing.

Also, there are sqlalchemy.url values in other env files.

This bug covers fixing this and making sure it's all correct because this is fiddling and complicated.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this now.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4004 - fix alembic

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/32395c05a72e5b35f9712803dd908423731f9c5c
fixes bug 1394834 - fix alembic in local dev environment (#4004)

Prior to this fix, alembic had the wrong sqlalchemy.url, so it was tricky to do
migration testing in the local dev environment.