1394840 - Move to the latest (at least 4.7) version of the Adjust SDK

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, enhancement, P2)

Description

[Mike Kaply [:mkaply]]

Adjust built a new feature for us and it requires a later SDK.

We need to move to the latest

https://github.com/adjust/android_sdk

Comment 1

[Nevin Chen(Not active on Bugzilla)]

NI Joe and Wesly to help prioritize this

Comment 2

[Wesly Huang (EPM)]

This need to be after Gradle if requiring an SDK update, and unsure if it's a 58 thing. Need Joe's comment about the overall priority. P2 for now.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

Hi Mike, what features are you thinking of that will require the newer SDK?

Comment 4

[Mike Kaply [:mkaply]]

Adjust has made server side changes for us that require the new SDK.

> Just to clarify, for this feature we'd need you to have at least v4.7.0 of the Adjust Android SDK, but we'd recommend updating to the newest which is v4.11.4 . Currently we can see you using only v4.0.0.

It's related to allowing us to track installs from other stores besides Google Play.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[triage] Non-critical unless mkaply says otherwise (if so, please move to P1).

Comment 6

[Mike Kaply [:mkaply]]

The need for this has lessened a bit (with our move away from focusing on mobile disto), but our Adjust SDK is VERY dated and we should think about getting it updated.

Comment 7

[:sdaswani]

Marketing has required we update Adjust ASAP too, so following on with Mike's suggestions.

Mike, would you happen to know how involved this work is? S M L? 

https://github.com/adjust/android_sdk#gpr-api

Comment 8

[Mike Kaply [:mkaply]]

I assume you meant to needinfo me.

I do not know how involved this work is.

It's the same major version (4.x) so I would hope the external API didn't change very much.

We have contact with the Adjust team if we run into issues.

Comment 9

[:sdaswani]

Mike, I did mean to NI Mike C., as I may have to have him or a contractor take on this work for 60. Do you think someone like Nick Alexander can take this work on easily? Or perhaps someone from your team? If not, I will figure it out on my end.

Comment 10

[Mike Kaply [:mkaply]]

Bringing back the Mike C needinfo. I think Nick could probably do this pretty easily. An Android person with build experience is probably best. I tried to look at it, but I just don't know enough Android.

Comment 11

[:sdaswani]

Nick can you pick up this work for 60?

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

> Mike, would you happen to know how involved this work is? S M L? 

My intuition says:
1) (M-L) Vet the updated source code for privacy concerns. I think this was given to an external team when we initially added adjust
2) (S - trivial) Update the gradle build scripts with the new version
3) Add the artifacts of the new dependencies to the builders. (M) if the old tooling still works, (L) otherwise

I'd expect Nick could do #3 much more efficiently than I could.

Comment 13

[:sdaswani]

(In reply to Michael Comella (:mcomella) [needinfo or I won't see it] from comment #12)
> > Mike, would you happen to know how involved this work is? S M L? 
> 
> My intuition says:
> 1) (M-L) Vet the updated source code for privacy concerns. I think this was
> given to an external team when we initially added adjust
> 2) (S - trivial) Update the gradle build scripts with the new version
> 3) Add the artifacts of the new dependencies to the builders. (M) if the old
> tooling still works, (L) otherwise
> 
> I'd expect Nick could do #3 much more efficiently than I could.

Thanks Mike!

Comment 14

[Nick Alexander :nalexander [he/him]]

(In reply to Susheel Daswani from comment #13)
> (In reply to Michael Comella (:mcomella) [needinfo or I won't see it] from
> comment #12)
> > > Mike, would you happen to know how involved this work is? S M L? 
> > 
> > My intuition says:
> > 1) (M-L) Vet the updated source code for privacy concerns. I think this was
> > given to an external team when we initially added adjust
> > 2) (S - trivial) Update the gradle build scripts with the new version
> > 3) Add the artifacts of the new dependencies to the builders. (M) if the old
> > tooling still works, (L) otherwise
> > 
> > I'd expect Nick could do #3 much more efficiently than I could.
> 
> Thanks Mike!

This isn't my remit these days, but it shouldn't be difficult.  The hard parts have nothing to do with the build system: we have to determine what changes we made to Adjust locally (and I know we worked around crashes), then determine what changed upstream, and reconcile the two.  If we can just take upstream, it's trivial to do in the Gradle builds, and we could always drop the --without-gradle builds for this...  But I expect we can't just take upstream, and therefore have to do the hard parts.

In any case, I have few cycles for Fennec maintenance these days, so I won't sign up for this at this time.

Comment 15

[Julien Cristau [:jcristau] (back April 22)]

Susheel, 60 goes in soft code freeze end of next week, is this still expected to make that deadline?

Comment 16

[:sdaswani]

Probably not Julien - moving it to 61.

Comment 17

[:sdaswani]

Barbara, can you put this on your prioritized list?

Comment 18

[Chris Peterson [:cpeterson]]

Downgrading priority from P1 to P2

Comment 19

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.