Closed
Bug 1394840
Opened 7 years ago
Closed 3 years ago
Move to the latest (at least 4.7) version of the Adjust SDK
Categories
(Firefox for Android Graveyard :: General, enhancement, P2)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: mkaply, Unassigned)
Details
Adjust built a new feature for us and it requires a later SDK. We need to move to the latest https://github.com/adjust/android_sdk
Comment 1•7 years ago
|
||
NI Joe and Wesly to help prioritize this
Flags: needinfo?(wehuang)
Flags: needinfo?(jcheng)
Comment 2•7 years ago
|
||
This need to be after Gradle if requiring an SDK update, and unsure if it's a 58 thing. Need Joe's comment about the overall priority. P2 for now.
Flags: needinfo?(wehuang)
Priority: -- → P2
Comment 3•7 years ago
|
||
Hi Mike, what features are you thinking of that will require the newer SDK?
Flags: needinfo?(jcheng) → needinfo?(mozilla)
Reporter | ||
Comment 4•7 years ago
|
||
Adjust has made server side changes for us that require the new SDK.
> Just to clarify, for this feature we'd need you to have at least v4.7.0 of the Adjust Android SDK, but we'd recommend updating to the newest which is v4.11.4 . Currently we can see you using only v4.0.0.
It's related to allowing us to track installs from other stores besides Google Play.
Flags: needinfo?(mozilla)
[triage] Non-critical unless mkaply says otherwise (if so, please move to P1).
Priority: P2 → P3
Reporter | ||
Comment 6•6 years ago
|
||
The need for this has lessened a bit (with our move away from focusing on mobile disto), but our Adjust SDK is VERY dated and we should think about getting it updated.
Marketing has required we update Adjust ASAP too, so following on with Mike's suggestions. Mike, would you happen to know how involved this work is? S M L? https://github.com/adjust/android_sdk#gpr-api
Reporter | ||
Comment 8•6 years ago
|
||
I assume you meant to needinfo me. I do not know how involved this work is. It's the same major version (4.x) so I would hope the external API didn't change very much. We have contact with the Adjust team if we run into issues.
Flags: needinfo?(michael.l.comella)
Mike, I did mean to NI Mike C., as I may have to have him or a contractor take on this work for 60. Do you think someone like Nick Alexander can take this work on easily? Or perhaps someone from your team? If not, I will figure it out on my end.
Flags: needinfo?(mozilla)
Reporter | ||
Comment 10•6 years ago
|
||
Bringing back the Mike C needinfo. I think Nick could probably do this pretty easily. An Android person with build experience is probably best. I tried to look at it, but I just don't know enough Android.
Flags: needinfo?(mozilla) → needinfo?(michael.l.comella)
Updated•6 years ago
|
status-firefox60:
--- → affected
> Mike, would you happen to know how involved this work is? S M L?
My intuition says:
1) (M-L) Vet the updated source code for privacy concerns. I think this was given to an external team when we initially added adjust
2) (S - trivial) Update the gradle build scripts with the new version
3) Add the artifacts of the new dependencies to the builders. (M) if the old tooling still works, (L) otherwise
I'd expect Nick could do #3 much more efficiently than I could.
Flags: needinfo?(michael.l.comella)
Comment 13•6 years ago
|
||
(In reply to Michael Comella (:mcomella) [needinfo or I won't see it] from comment #12) > > Mike, would you happen to know how involved this work is? S M L? > > My intuition says: > 1) (M-L) Vet the updated source code for privacy concerns. I think this was > given to an external team when we initially added adjust > 2) (S - trivial) Update the gradle build scripts with the new version > 3) Add the artifacts of the new dependencies to the builders. (M) if the old > tooling still works, (L) otherwise > > I'd expect Nick could do #3 much more efficiently than I could. Thanks Mike!
Comment 14•6 years ago
|
||
(In reply to Susheel Daswani from comment #13) > (In reply to Michael Comella (:mcomella) [needinfo or I won't see it] from > comment #12) > > > Mike, would you happen to know how involved this work is? S M L? > > > > My intuition says: > > 1) (M-L) Vet the updated source code for privacy concerns. I think this was > > given to an external team when we initially added adjust > > 2) (S - trivial) Update the gradle build scripts with the new version > > 3) Add the artifacts of the new dependencies to the builders. (M) if the old > > tooling still works, (L) otherwise > > > > I'd expect Nick could do #3 much more efficiently than I could. > > Thanks Mike! This isn't my remit these days, but it shouldn't be difficult. The hard parts have nothing to do with the build system: we have to determine what changes we made to Adjust locally (and I know we worked around crashes), then determine what changed upstream, and reconcile the two. If we can just take upstream, it's trivial to do in the Gradle builds, and we could always drop the --without-gradle builds for this... But I expect we can't just take upstream, and therefore have to do the hard parts. In any case, I have few cycles for Fennec maintenance these days, so I won't sign up for this at this time.
Flags: needinfo?(nalexander)
Comment 15•6 years ago
|
||
Susheel, 60 goes in soft code freeze end of next week, is this still expected to make that deadline?
status-firefox60:
affected → ---
tracking-firefox60:
? → ---
Comment 17•6 years ago
|
||
Barbara, can you put this on your prioritized list?
Flags: needinfo?(sdaswani) → needinfo?(bbermes)
Updated•5 years ago
|
Flags: needinfo?(bbermes)
Comment 19•3 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•