1394874 - Undefined functions due to missing includes or function ordering in ipc/mscom/InterfaceRegistrationAnnotator.cpp

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Tom Ritter [:tjr]]

> error: no matching function for call to ‘GetStringValue
> error: ‘nsPrintfCString’ was not declared in this scope

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

FYI you might want to wait until 5b4d9dacb44d7c1fea47d1057e78395ca3da7b55 merges to central, as there will be merge conflicts.

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1394874 Fix function order and add include to fix MinGW build

nsPrintfCString.h was not included, so it caused an error
GetStringValue was called before it was defined

Review commit: https://reviewboard.mozilla.org/r/173864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173864/

Comment 3

[Tom Ritter [:tjr]]

If the patch looks good I can rebase it before landing.

Comment 5

[Tom Ritter [:tjr]]

I marked-as-duplicate the wrong bug

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8902327 [details]
Bug 1394874 Fix function order and add include to fix MinGW build

https://reviewboard.mozilla.org/r/173864/#review179132

Comment 7

[Tom Ritter [:tjr]]

Rebased now that the rev has landed.

Try run:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=2da78038151e5662948779e5bf502afba4bc7438

Once that's green I'll mark for checkin.

Comment 8

[Tom Ritter [:tjr]]

Comment on attachment 8902327 [details]
Bug 1394874 Fix function order and add include to fix MinGW build

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/173864/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f854addeb3f0
Fix function order and add include to fix MinGW build r=aklotz

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f854addeb3f0