Closed Bug 1394879 Opened 7 years ago Closed 7 years ago

Replace TouchDelegate usage with TouchDelegateWithReset

Categories

(Firefox for Android Graveyard :: General, enhancement)

All
Android
enhancement
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: JanH, Assigned: suneetbond91, Mentored)

Details

(Whiteboard: [good first bug][lang=java])

Attachments

(1 file)

We have a few places around the code base were we're still using the TouchDelegate class provided by the frame work. We should probably switch them all to using our own TouchDelegateWithReset class instead in order to work around a bug in Android's implementation (compare bug 1116415 comment 23).

So the course of action would be looking at https://dxr.mozilla.org/ to find all places where we're using TouchDelegates and replacing them with TouchDelegateWithReset.
Hi,Would like to work on this issue!
Flags: needinfo?(jh+bugzilla)
Hi, welcome. Sure, feel free to go ahead and work on this.

If you haven't already got a Firefox build going, you can find instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Instructions on how to submit a patch are here:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#mozreview-install

And if you've got any further questions, just ask or drop by on IRC (https://wiki.mozilla.org/IRC) in #mobile.
Flags: needinfo?(jh+bugzilla)
Need help regarding the build of Firefox for Android. I am getting some issues,mailed you for further assistance .
Copy
- your mozconfig
- the output of the failing build
into https://pastebin.mozilla.org/ and post the link to them. Also what kind of system are you using?
I am using Linux Ubuntu 16.04. I am stucked at the 

curl -O https://hg.mozilla.org/mozilla-central/raw-file/default/python/mozboot/bin/bootstrap.py && python bootstrap.py

After running this ! the following components are installed but it asks me to accept the license agreement for sdk linux and after entering y(yes) their are no proceeding execution.



Log:
We are now installing the following Android packages:
platform-tools
build-tools;23.0.3
platforms;android-23
extras;android;m2repository
extras;google;m2repository

You may be prompted to agree to the Android license. You may see some of
output as packages are downloaded and installed.

Warning: File /home/suneetsri/.android/repositories.cfg could not be loaded.
License android-sdk-license:
---------------------------------------
Terms and Conditions

This is the Android Software Development Kit License Agreement

1. Introduction

1.1 The Android Software Development Kit (referred to in the License Agreement as the "SDK" and specifically including the Android system files, packaged APIs, and Google APIs add-ons) is licensed to you subject to the terms of the License Agreement. The License Agreement forms a legally binding contract between you and Google in relation to your use of the SDK.

1.2 "Android" means the Android software stack for devices, as made available under the Android Open Source Project, which is located at the following URL: http://source.android.com/, as updated from time to time.

1.3 A "compatible implementation" means any Android device that (i) complies with the Android Compatibility Definition document, which can be found at the Android compatibility website (http://source.android.com/compatibility) and which may be updated from time to time; and (ii) successfully passes the Android Compatibility Test Suite (CTS).

1.4 "Google" means Google Inc., a Delaware corporation with principal place of business at 1600 Amphitheatre Parkway, Mountain View, CA 94043, United States.


2. Accepting the License Agreement

2.1 In order to use the SDK, you must first agree to the License Agreement. You may not use the SDK if you do not accept the License Agreement.

2.2 By clicking to accept, you hereby agree to the terms of the License Agreement.

2.3 You may not use the SDK and may not accept the License Agreement if you are a person barred from receiving the SDK under the laws of the United States or other countries, including the country in which you are resident or from which you use the SDK.

2.4 If you are agreeing to be bound by the License Agreement on behalf of your employer or other entity, you represent and warrant that you have full legal authority to bind your employer or such entity to the License Agreement. If you do not have the requisite authority, you may not accept the License Agreement or use the SDK on behalf of your employer or other entity.


3. SDK License from Google

3.1 Subject to the terms of the License Agreement, Google grants you a limited, worldwide, royalty-free, non-assignable, non-exclusive, and non-sublicensable license to use the SDK solely to develop applications for compatible implementations of Android.

3.2 You may not use this SDK to develop applications for other platforms (including non-compatible implementations of Android) or to develop another SDK. You are of course free to develop applications for other platforms, including non-compatible implementations of Android, provided that this SDK is not used for that purpose.

3.3 You agree that Google or third parties own all legal right, title and interest in and to the SDK, including any Intellectual Property Rights that subsist in the SDK. "Intellectual Property Rights" means any and all rights under patent law, copyright law, trade secret law, trademark law, and any and all other proprietary rights. Google reserves all rights not expressly granted to you.

3.4 You may not use the SDK for any purpose not expressly permitted by the License Agreement. Except to the extent required by applicable third party licenses, you may not: (a) copy (except for backup purposes), modify, adapt, redistribute, decompile, reverse engineer, disassemble, or create derivative works of the SDK or any part of the SDK; or (b) load any part of the SDK onto a mobile handset or any other hardware device except a personal computer, combine any part of the SDK with other software, or distribute any software or device incorporating a part of the SDK.

3.5 Use, reproduction and distribution of components of the SDK licensed under an open source software license are governed solely by the terms of that open source software license and not the License Agreement.

3.6 You agree that the form and nature of the SDK that Google provides may change without prior notice to you and that future versions of the SDK may be incompatible with applications developed on previous versions of the SDK. You agree that Google may stop (permanently or temporarily) providing the SDK (or any features within the SDK) to you or to users generally at Google's sole discretion, without prior notice to you.

3.7 Nothing in the License Agreement gives you a right to use any of Google's trade names, trademarks, service marks, logos, domain names, or other distinctive brand features.

3.8 You agree that you will not remove, obscure, or alter any proprietary rights notices (including copyright and trademark notices) that may be affixed to or contained within the SDK.


4. Use of the SDK by You

4.1 Google agrees that it obtains no right, title or interest from you (or your licensors) under the License Agreement in or to any software applications that you develop using the SDK, including any intellectual property rights that subsist in those applications.

4.2 You agree to use the SDK and write applications only for purposes that are permitted by (a) the License Agreement and (b) any applicable law, regulation or generally accepted practices or guidelines in the relevant jurisdictions (including any laws regarding the export of data or software to and from the United States or other relevant countries).

4.3 You agree that if you use the SDK to develop applications for general public users, you will protect the privacy and legal rights of those users. If the users provide you with user names, passwords, or other login information or personal information, you must make the users aware that the information will be available to your application, and you must provide legally adequate privacy notice and protection for those users. If your application stores personal or sensitive information provided by users, it must do so securely. If the user provides your application with Google Account information, your application may only use that information to access the user's Google Account when, and for the limited purposes for which, the user has given you permission to do so.

4.4 You agree that you will not engage in any activity with the SDK, including the development or distribution of an application, that interferes with, disrupts, damages, or accesses in an unauthorized manner the servers, networks, or other properties or services of any third party including, but not limited to, Google or any mobile communications carrier.

4.5 You agree that you are solely responsible for (and that Google has no responsibility to you or to any third party for) any data, content, or resources that you create, transmit or display through Android and/or applications for Android, and for the consequences of your actions (including any loss or damage which Google may suffer) by doing so.

4.6 You agree that you are solely responsible for (and that Google has no responsibility to you or to any third party for) any breach of your obligations under the License Agreement, any applicable third party contract or Terms of Service, or any applicable law or regulation, and for the consequences (including any loss or damage which Google or any third party may suffer) of any such breach.

5. Your Developer Credentials

5.1 You agree that you are responsible for maintaining the confidentiality of any developer credentials that may be issued to you by Google or which you may choose yourself and that you will be solely responsible for all applications that are developed under your developer credentials.

6. Privacy and Information

6.1 In order to continually innovate and improve the SDK, Google may collect certain usage statistics from the software including but not limited to a unique identifier, associated IP address, version number of the software, and information on which tools and/or services in the SDK are being used and how they are being used. Before any of this information is collected, the SDK will notify you and seek your consent. If you withhold consent, the information will not be collected.

6.2 The data collected is examined in the aggregate to improve the SDK and is maintained in accordance with Google's Privacy Policy.


7. Third Party Applications

7.1 If you use the SDK to run applications developed by a third party or that access data, content or resources provided by a third party, you agree that Google is not responsible for those applications, data, content, or resources. You understand that all data, content or resources which you may access through such third party applications are the sole responsibility of the person from which they originated and that Google is not liable for any loss or damage that you may experience as a result of the use or access of any of those third party applications, data, content, or resources.

7.2 You should be aware the data, content, and resources presented to you through such a third party application may be protected by intellectual property rights which are owned by the providers (or by other persons or companies on their behalf). You may not modify, rent, lease, loan, sell, distribute or create derivative works based on these data, content, or resources (either in whole or in part) unless you have been specifically given permission to do so by the relevant owners.

7.3 You acknowledge that your use of such third party applications, data, content, or resources may be subject to separate terms between you and the relevant third party. In that case, the License Agreement does not affect your legal relationship with these third parties.


8. Using Android APIs

8.1 Google Data APIs

8.1.1 If you use any API to retrieve data from Google, you acknowledge that the data may be protected by intellectual property rights which are owned by Google or those parties that provide the data (or by other persons or companies on their behalf). Your use of any such API may be subject to additional Terms of Service. You may not modify, rent, lease, loan, sell, distribute or create derivative works based on this data (either in whole or in part) unless allowed by the relevant Terms of Service.

8.1.2 If you use any API to retrieve a user's data from Google, you acknowledge and agree that you shall retrieve data only with the user's explicit consent and only when, and for the limited purposes for which, the user has given you permission to do so.


9. Terminating the License Agreement

9.1 The License Agreement will continue to apply until terminated by either you or Google as set out below.

9.2 If you want to terminate the License Agreement, you may do so by ceasing your use of the SDK and any relevant developer credentials.

9.3 Google may at any time, terminate the License Agreement with you if: (A) you have breached any provision of the License Agreement; or (B) Google is required to do so by law; or (C) the partner with whom Google offered certain parts of SDK (such as APIs) to you has terminated its relationship with Google or ceased to offer certain parts of the SDK to you; or (D) Google decides to no longer provide the SDK or certain parts of the SDK to users in the country in which you are resident or from which you use the service, or the provision of the SDK or certain SDK services to you by Google is, in Google's sole discretion, no longer commercially viable.

9.4 When the License Agreement comes to an end, all of the legal rights, obligations and liabilities that you and Google have benefited from, been subject to (or which have accrued over time whilst the License Agreement has been in force) or which are expressed to continue indefinitely, shall be unaffected by this cessation, and the provisions of paragraph 14.7 shall continue to apply to such rights, obligations and liabilities indefinitely.


10. DISCLAIMER OF WARRANTIES

10.1 YOU EXPRESSLY UNDERSTAND AND AGREE THAT YOUR USE OF THE SDK IS AT YOUR SOLE RISK AND THAT THE SDK IS PROVIDED "AS IS" AND "AS AVAILABLE" WITHOUT WARRANTY OF ANY KIND FROM GOOGLE.

10.2 YOUR USE OF THE SDK AND ANY MATERIAL DOWNLOADED OR OTHERWISE OBTAINED THROUGH THE USE OF THE SDK IS AT YOUR OWN DISCRETION AND RISK AND YOU ARE SOLELY RESPONSIBLE FOR ANY DAMAGE TO YOUR COMPUTER SYSTEM OR OTHER DEVICE OR LOSS OF DATA THAT RESULTS FROM SUCH USE.

10.3 GOOGLE FURTHER EXPRESSLY DISCLAIMS ALL WARRANTIES AND CONDITIONS OF ANY KIND, WHETHER EXPRESS OR IMPLIED, INCLUDING, BUT NOT LIMITED TO THE IMPLIED WARRANTIES AND CONDITIONS OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT.


11. LIMITATION OF LIABILITY

11.1 YOU EXPRESSLY UNDERSTAND AND AGREE THAT GOOGLE, ITS SUBSIDIARIES AND AFFILIATES, AND ITS LICENSORS SHALL NOT BE LIABLE TO YOU UNDER ANY THEORY OF LIABILITY FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, CONSEQUENTIAL OR EXEMPLARY DAMAGES THAT MAY BE INCURRED BY YOU, INCLUDING ANY LOSS OF DATA, WHETHER OR NOT GOOGLE OR ITS REPRESENTATIVES HAVE BEEN ADVISED OF OR SHOULD HAVE BEEN AWARE OF THE POSSIBILITY OF ANY SUCH LOSSES ARISING.


12. Indemnification

12.1 To the maximum extent permitted by law, you agree to defend, indemnify and hold harmless Google, its affiliates and their respective directors, officers, employees and agents from and against any and all claims, actions, suits or proceedings, as well as any and all losses, liabilities, damages, costs and expenses (including reasonable attorneys fees) arising out of or accruing from (a) your use of the SDK, (b) any application you develop on the SDK that infringes any copyright, trademark, trade secret, trade dress, patent or other intellectual property right of any person or defames any person or violates their rights of publicity or privacy, and (c) any non-compliance by you with the License Agreement.


13. Changes to the License Agreement

13.1 Google may make changes to the License Agreement as it distributes new versions of the SDK. When these changes are made, Google will make a new version of the License Agreement available on the website where the SDK is made available.


14. General Legal Terms

14.1 The License Agreement constitutes the whole legal agreement between you and Google and governs your use of the SDK (excluding any services which Google may provide to you under a separate written agreement), and completely replaces any prior agreements between you and Google in relation to the SDK.

14.2 You agree that if Google does not exercise or enforce any legal right or remedy which is contained in the License Agreement (or which Google has the benefit of under any applicable law), this will not be taken to be a formal waiver of Google's rights and that those rights or remedies will still be available to Google.

14.3 If any court of law, having the jurisdiction to decide on this matter, rules that any provision of the License Agreement is invalid, then that provision will be removed from the License Agreement without affecting the rest of the License Agreement. The remaining provisions of the License Agreement will continue to be valid and enforceable.

14.4 You acknowledge and agree that each member of the group of companies of which Google is the parent shall be third party beneficiaries to the License Agreement and that such other companies shall be entitled to directly enforce, and rely upon, any provision of the License Agreement that confers a benefit on (or rights in favor of) them. Other than this, no other person or company shall be third party beneficiaries to the License Agreement.

14.5 EXPORT RESTRICTIONS. THE SDK IS SUBJECT TO UNITED STATES EXPORT LAWS AND REGULATIONS. YOU MUST COMPLY WITH ALL DOMESTIC AND INTERNATIONAL EXPORT LAWS AND REGULATIONS THAT APPLY TO THE SDK. THESE LAWS INCLUDE RESTRICTIONS ON DESTINATIONS, END USERS AND END USE.

14.6 The rights granted in the License Agreement may not be assigned or transferred by either you or Google without the prior written approval of the other party. Neither you nor Google shall be permitted to delegate their responsibilities or obligations under the License Agreement without the prior written approval of the other party.

14.7 The License Agreement, and your relationship with Google under the License Agreement, shall be governed by the laws of the State of California without regard to its conflict of laws provisions. You and Google agree to submit to the exclusive jurisdiction of the courts located within the county of Santa Clara, California to resolve any legal matter arising from the License Agreement. Notwithstanding this, you agree that Google shall still be allowed to apply for injunctive remedies (or an equivalent type of urgent legal relief) in any jurisdiction.


November 20, 2015
---------------------------------------
Accept? (y/N): y
I saw this in back scroll on IRC but couldn't reply.  There will be a very large download happening after you accept -- can you try again, and use a system monitor or similar to figure out if there's network activity happening?  If not, then we might have a problem -- maybe stdin is getting buffered or something.  But I'd suspect a slow connection and no progress updates before anything else.
:JanH Guide me whether I have to setup the frontend or the backend part of the mozilla?
Getting this error in frontend build :(

./mach build
 0:00.18 /usr/bin/make -f client.mk -s
 0:00.97 Adding client.mk options from /home/suneetsri/mozilla-central/mozconfig:
 0:00.98     CONFIG_GUESS=arm-linux-androideabi
 0:00.98     MOZ_OBJDIR=/home/suneetsri/mozilla-central/objdir-frontend
 0:00.98     OBJDIR=/home/suneetsri/mozilla-central/objdir-frontend
 0:00.98     FOUND_MOZCONFIG=/home/suneetsri/mozilla-central/mozconfig
 0:01.93 Error running mach:
 0:01.93 
 0:01.93     ['--log-no-times', 'artifact', 'install']
 0:01.93 
 0:01.93 The error occurred in code that was called by the mach command. This is either
 0:01.93 a bug in the called code itself or in the way that mach is calling it.
 0:01.93 
 0:01.93 You should consider filing a bug for this issue.
 0:01.93 
 0:01.93 If filing a bug, please include the full output of mach, including this error
 0:01.94 message.
 0:01.94 
 0:01.94 The details of the failure are as follows:
 0:01.94 
 0:01.94 IndexError: list index out of range
 0:01.94 
 0:01.94   File "/home/suneetsri/mozilla-central/python/mozbuild/mozbuild/mach_commands.py", line 1731, in artifact_install
 0:01.94     return artifacts.install_from(source, self.distdir)
 0:01.94   File "/home/suneetsri/mozilla-central/python/mozbuild/mozbuild/artifacts.py", line 1154, in install_from
 0:01.94     return self.install_from_recent(distdir)
 0:01.94   File "/home/suneetsri/mozilla-central/python/mozbuild/mozbuild/artifacts.py", line 1115, in install_from_recent
 0:01.94     return self._install_from_hg_pushheads(hg_pushheads, distdir)
 0:01.94   File "/home/suneetsri/mozilla-central/python/mozbuild/mozbuild/artifacts.py", line 1094, in _install_from_hg_pushheads
 0:01.94     for trees, hg_hash in hg_pushheads:
 0:01.94   File "/home/suneetsri/mozilla-central/python/mozbuild/mozbuild/artifacts.py", line 995, in _find_pushheads
 0:01.94     candidate_pushheads = self._pushheads_from_rev(last_revs[0].rstrip(),
 0:01.95 Makefile:222: recipe for target 'recurse_artifact' failed
 0:01.95 make[4]: *** [recurse_artifact] Error 1
 0:01.95 /home/suneetsri/mozilla-central/config/recurse.mk:32: recipe for target 'artifact' failed
 0:01.95 make[3]: *** [artifact] Error 2
 0:01.95 /home/suneetsri/mozilla-central/config/rules.mk:453: recipe for target 'default' failed
 0:01.95 make[2]: *** [default] Error 2
 0:01.95 /home/suneetsri/mozilla-central/client.mk:424: recipe for target 'realbuild' failed
 0:01.95 make[1]: *** [realbuild] Error 2
 0:01.95 client.mk:175: recipe for target 'build' failed
 0:01.95 make: *** [build] Error 2
 0:02.00 0 compiler warnings present.
JanH I have made the build on my system successfully ! Guide me further to solve the issue ! I have build the frontend part of the firefox.
Yes, frontend is fine, as this is concerning Java code only.

As I said above, use https://dxr.mozilla.org/ [1] or http://searchfox.org/ [2] to search for all places where we're instantiating a new TouchDelegate and then replace them with TouchDelegateWithReset, so we're using our own fixed version everywhere.

[1] You can restrict the search to Android code by adding "path:mobile"
[2] On Searchfox, there's a separate search box for a path filter where you can simply enter "mobile"
I will be working on this issue ! Please provide ur IRC so that we can connect better as I can't comment every time I m stuck or need help ..
JanH, as shown in my Bugzilla username.
Assignee: nobody → suneetbond91
JanH the bug is fixed.Kindly guide me regarding the building of patch.
Comment on attachment 8907780 [details]
Bug 1394879 - Replaced TouchDelegate usage with TouchDelegateWithReset .

https://reviewboard.mozilla.org/r/179464/#review184646

::: mobile/android/base/java/org/mozilla/gecko/tabs/TabStrip.java
(Diff revision 2)
>                      r.top = 0;
>                      r.bottom = getHeight();
>  
>                      // Redirect touch events between the 'new tab' button and the edge
>                      // of the screen to the 'new tab' button.
> -                    setTouchDelegate(new TouchDelegate(r, addTabButton));

Nit: The newline after the comment block isn't needed, you can remove it again.

::: mobile/android/base/java/org/mozilla/gecko/util/TouchTargetUtil.java:43
(Diff revision 2)
>  
>                  if (heightDelta <= 0 && widthDelta <= 0) {
>                      return;
>                  }
>  
> -                TouchDelegate touchDelegate = new TouchDelegate(delegateArea, targetView);
> +                TouchDelegateWithReset touchDelegateWithReset = new TouchDelegateWithReset(delegateArea, targetView);

You can leave the start as `TouchDelegate touchDelegate = `, only the part after the `new` needs changing.
Comment on attachment 8907780 [details]
Bug 1394879 - Replaced TouchDelegate usage with TouchDelegateWithReset .

https://reviewboard.mozilla.org/r/179464/#review184658
Attachment #8907780 - Flags: review?(jh+bugzilla) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/95bcc263da5e
Replaced TouchDelegate usage with TouchDelegateWithReset .r=JanH
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/95bcc263da5e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.