Open
Bug 1394958
Opened 7 years ago
Updated 2 years ago
Find API - Change pos to index in rangeData
Categories
(WebExtensions :: General, enhancement, P5)
WebExtensions
General
Tracking
(firefox57 wontfix)
NEW
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | wontfix |
People
(Reporter: ntim, Unassigned)
References
Details
(Whiteboard: [find])
The rangeData object contains startTextNodePos, endTextNodePos, framePos.
Since those are just indices, I would change "Pos" to "Index".
|
Reporter | |
Updated•7 years ago
|
Component: Untriaged → WebExtensions: General
Product: Firefox → Toolkit
|
|
Reporter | |
Updated•7 years ago
|
Flags: needinfo?(mixedpuppy)
|
|
Reporter | |
Comment 1•7 years ago
|
||
Additionally, there's a rangeIndex param in highlightResults, I would rename it to resultId.
|
||
Updated•7 years ago
|
Flags: needinfo?(mixedpuppy) → needinfo?(kevinhowjones)
Whiteboard: [find]
IMO the differences mentioned seem trivial and in the bike-shedding realm, and I don't think it is worth investing in the rigors of landing a bug over. Myself and two reviewers seemed happy with it the way it is.
Flags: needinfo?(kevinhowjones)
|
|
||
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Priority: -- → P5
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
|
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•