Closed
Bug 1394960
Opened 8 years ago
Closed 8 years ago
Autophone - add android-api-16 as a supported platform
Categories
(Testing Graveyard :: Autophone, enhancement)
Testing Graveyard
Autophone
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(2 files)
|
41.04 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
|
1.52 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
With the minimum platform now android-api-16 autophone needs to have this as a supported platform. Note also we need to also add it to trychooser.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8902450 -
Flags: review?(jmaher)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8902450 [details] [diff] [review]
bug-1394960-v1.patch
Review of attachment 8902450 [details] [diff] [review]:
-----------------------------------------------------------------
lots of simple changes
Attachment #8902450 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://github.com/mozilla/autophone/commit/bdaafc7173a58fe95785fa03a4519e22788ca2d2
deployed 2017-08-29 16:00
jmaher: Thanks!
|
|
Assignee | |
Comment 4•8 years ago
|
||
spoke too soon. I missed some api-xx values.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 5•8 years ago
|
||
Attachment #8902474 -
Flags: review?(jmaher)
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8902474 [details] [diff] [review]
bug-1394960-v2.patch
Review of attachment 8902474 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #8902474 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
Thanks again. I deployed on autophone-4 and confirmed that trigger worked. Deploying to the others now.
https://github.com/mozilla/autophone/commit/f7a2fa504afa0c8a7313dfbe4a44cbc8c7c73f8f
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•