Open Bug 1394967 Opened 7 years ago Updated 1 year ago

Intermittent browser_screenshots_ui_check.js | leaked 1 window(s) until shutdown [url = _generated_background_page.html]

Categories

(Firefox :: Screenshots, defect, P5)

Product:
Firefox
Component:
Screenshots
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- disabled
firefox59 --- disabled

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [screenshots-extension])

Summary: Intermittent browser/extensions/screenshots/test/browser/browser_screenshots_ui_check.js | leaked 1 window(s) until shutdown [url = moz-extension://dab63b88-4cce-47b5-80da-e3cddfb51c07/_generated_background_page.html] → Intermittent browser_screenshots_ui_check.js | leaked 1 window(s) until shutdown [url = _generated_background_page.html]
Product: Cloud Services → Firefox
There are 32 failures in the last 7 days.
Flags: needinfo?(ianb)
Whiteboard: [stockwell needswork]
this is all failing on win10 debug configs, here is a recent log:
https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=144250578&lineNumber=29533

I am not an expert at deciphering the logs to determine what leaked, hopefully this is something that is easy to determine from the logs and fix!
See Also: → 1414673
We've had a number of recurring bugs where extension shutdown isn't blocked on extension startup completing. This tends to show up as windows not getting cleaned up, or tests hanging forever.

:aswan, do you think these failures might be related to any recent changes in addon management code?
Flags: needinfo?(ianb) → needinfo?(aswan)
(In reply to Jared Hirsch [:_6a68] [:jhirsch] from comment #13)
> We've had a number of recurring bugs where extension shutdown isn't blocked
> on extension startup completing. This tends to show up as windows not
> getting cleaned up, or tests hanging forever.
> 
> :aswan, do you think these failures might be related to any recent changes
> in addon management code?

I can't think of anything particularly recent but doesn't screenshots handle starting and stopping its webextension itself?  Or is this a problem with extensions other than screenshots?
Flags: needinfo?(aswan)
> I can't think of anything particularly recent but doesn't screenshots handle starting and stopping its webextension itself?

Yeah, and we wait to start the webextension until 'sessionstore-windows-restored' has fired.

It seems weird that the failure rate jumped up on the 19th (see the link in comment 12), as no Screenshots code landed around that time.

Also, the fact that this is specific to win 10 debug (comment 10) makes me wonder if it's some kind of process shutdown issue again.

I dunno. :aswan, any other stuff that comes to mind? :jmaher, are these errors still mostly on win 10, and if so, any guess as to which pushlog could be involved?
Flags: needinfo?(jmaher)
Flags: needinfo?(aswan)
the failures still remain windows10-debug;  as for the failure rate increase on the 19th, that is a weekend, we don't run these tests every push, and on weekends we typically run every push- so the weekends highlight a more realistic failure rate.  the rate will drop down as we turned off stylo-disabled tests for win10 yesterday- but we still have failures on regular stylo configurations.
Flags: needinfo?(jmaher)
So is the problem with the webextension or the bootstrapped part not getting fully shut down?  If you're calling shutdown() on the webextension from the bootstrap shutdown(), the webextension bits should block shutdown.  Are you doing anything else asynchronous from bootstrap shutdown() ?
Flags: needinfo?(aswan)
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/022462be713f
Disable browser_screenshots_ui_check.js on windows debug for frequent failures. r=me, a=testonly
please remember that this test is disabled and to enable it in the manifest prior to working a fix for the test case.
Keywords: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Severity: normal → S3
Whiteboard: [stockwell disabled] → [screenshots-extension]
You need to log in before you can comment on or make changes to this bug.