1395032 - Remove remainder of the VS CRT allocator mismatch hack

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1395032 - Remove remainder of the VS CRT allocator mismatch hack.

Bug 1186064 removed most of it when we started requiring VS 2015u2, but
the "frex" function exported through mozglue.def.in was only used
through the MSVCRT being patched by fixcrt.py, which is not done anymore.
So the "frex" export is not used anymore, and so the "dumb_free_thunk"
function is not used anymore as well.

Review commit: https://reviewboard.mozilla.org/r/174118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174118/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8902525 [details]
Bug 1395032 - Remove remainder of the VS CRT allocator mismatch hack.

https://reviewboard.mozilla.org/r/174118/#review179658

I'll rubber stamp this. But I'd feel better if someone like froydnj reviewed changes like this going forward.

Comment 3

[Mike Hommey [:glandium]]

FWIW, I flagged you because you did the partial removal in bug 1186064.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73f1010eea4c
Remove remainder of the VS CRT allocator mismatch hack. r=gps

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/73f1010eea4c