1395098 - Folded-down text opacity not respected with webrender (both layers + layers-free affected)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Markus Stange [:mstange]]

Attachment: testcase

The text in this testcase should be almost invisible. With WebRender it's painted with the full black color.

I think this happens because the call to nsDisplayText::ApplyOpacity is effectively ignored when WebRender is used, because RenderToContext() (which records the text drawing commands) runs during the nsDisplayText constructor, at which point the folded-down opacity is not yet known.

Comment 1

[Aria Beingessner [:Gankra]]

Attachment: Bug 1395098 - Apply folded alpha to text when using advanced layers

Review commit: https://reviewboard.mozilla.org/r/174446/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174446/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8902780 [details]
Bug 1395098 - Apply folded alpha to text when using advanced layers

https://reviewboard.mozilla.org/r/174446/#review179608

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7663f58bcf96
Apply folded alpha to text when using advanced layers r=jrmuizel

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7663f58bcf96