1395124 - Leanplum events (E_First_Run and E_Second_Run) not firing correctly when first launching the app

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Attachment: Screen Shot 2017-08-30 at 14.21.24.png

Build: master b259426ff1a
Device: iPhone 7
iOS: 10.3.3

Steps to reproduce: 
1. Clean install Firefox
2. Launch Firefox
3. Register the device to Leanplum
4. Check the event trail

Actual results: 
- At the first run with an unregistered device I sometimes see the E_First_Run event and sometimes see the E_Second_Run event being triggered on the first run. 

Expected results:
- On the first run we should always trigger E_First_Run event and after closing the app and re-opening we should see the E_Second_Run event being triggered (on the second run).

Note: 
- If the E_First_Run event is correctly triggered on the first run then the E_Second_Run event will also be triggered correctly on the second run.

Comment 1

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 2

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/631c2932d3c81e280ffd73856b1ced24967c7a2d

Comment 3

[Simon Basca [:SimonB]]

Verifying as fix on master 631c2932d3c81e. The events are firing correctly.

Comment 4

[Simon Basca [:SimonB]]

Verifying as fix on beta 8.3(5817).