Closed
Bug 1395170
Opened 7 years ago
Closed 7 years ago
Lint errors/warnings in BasicGeckoViewPrompt
Categories
(GeckoView :: General, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(1 file)
|
21.62 KB,
patch
|
droeh
:
review+
|
Details | Diff | Splinter Review |
BasicGeckoViewPrompt contains some lint errors/warnings that we should fix.
|
Assignee | |
Comment 1•7 years ago
|
||
Fix the following lint errors/warnings, * Using inlined constants on older versions Add version check for usages of Intent.EXTRA_ALLOW_MULTIPLE and Intent.EXTRA_MIME_TYPES. * Calling new methods on older versions Change usages of AlertDialog.Builder#setOnDismissListener to Dialog#setOnDismissListener instead. * Missing recycle() calls Add missing TypedArray#recycle call
Attachment #8902706 -
Flags: review?(droeh)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8902706 [details] [diff] [review] Fix lint warnings/errors from BasicGeckoViewPrompt (v1) Review of attachment 8902706 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8902706 -
Flags: review?(droeh) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0f25af758ee4 Fix lint warnings/errors from BasicGeckoViewPrompt; r=droeh
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0f25af758ee4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
|
||
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•5 years ago
|
Target Milestone: Firefox 57 → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•