1395170 - Lint errors/warnings in BasicGeckoViewPrompt

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

BasicGeckoViewPrompt contains some lint errors/warnings that we should fix.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Fix lint warnings/errors from BasicGeckoViewPrompt (v1)

Fix the following lint errors/warnings,

* Using inlined constants on older versions
  Add version check for usages of Intent.EXTRA_ALLOW_MULTIPLE and
  Intent.EXTRA_MIME_TYPES.

* Calling new methods on older versions
  Change usages of AlertDialog.Builder#setOnDismissListener to
  Dialog#setOnDismissListener instead.

* Missing recycle() calls
  Add missing TypedArray#recycle call

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8902706 [details] [diff] [review]
Fix lint warnings/errors from BasicGeckoViewPrompt (v1)

Review of attachment 8902706 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f25af758ee4
Fix lint warnings/errors from BasicGeckoViewPrompt; r=droeh

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0f25af758ee4