1395189 - stylo: -webkit-linear-gradient defaults to "bottom" as start side (but should default to "top")

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

Attachment: testcase 1

STR:
 1. Load attached testcase.

EXPECTED RESULTS:
 The side by side divs should look the same.

ACTUAL RESULTS:
 The first div (the one that doesn't specify a start-side for its gradient) has its gradient backwards -- it has blue at the top instead of red.

Comment 1

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

Chrome and Firefox Nightly without stylo gives EXPECTED RESULTS.

Firefox Nightly with stylo gives ACTUAL RESULTS.

Comment 2

[Bobby Holley (:bholley)]

Nazim, can you have a look?

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1395189 - stylo: Properly set direction of prefixed linear gradients

The default linear gradient direction is `to bottom`. This correspondes to
`top` keyword in prefixed linear gradients. We should preserve the default value

Review commit: https://reviewboard.mozilla.org/r/174522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174522/

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

This patch works on my local build. Will do a try run to see.

Comment 5

[Manish Goregaokar [:manishearth]]

Comment on attachment 8902836 [details]
Bug 1395189 - stylo: Properly set direction of prefixed linear gradients

https://reviewboard.mozilla.org/r/174522/#review179654

Comment 6

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1395189 - Add reftest for default directions of prefixed linear gradients

Review commit: https://reviewboard.mozilla.org/r/174558/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174558/

Comment 7

[Manish Goregaokar [:manishearth]]

Comment on attachment 8902865 [details]
Bug 1395189 - Add reftest for default directions of prefixed linear gradients

https://reviewboard.mozilla.org/r/174558/#review179664

Comment 8

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

Could you move the reftest to the layout/reftests/webkit-gradient directory (rather than in the modern "css-gradients" directory)?

Thanks for the quick action on the fix, BTW!

Comment 9

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Comment on attachment 8902865 [details]
Bug 1395189 - Add reftest for default directions of prefixed linear gradients

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/174558/diff/1-2/

Comment 10

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Moved thanks!

I'll open a PR and land this after the previous try run finishes.

Comment 11

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Comment on attachment 8902836 [details]
Bug 1395189 - stylo: Properly set direction of prefixed linear gradients

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/174522/diff/1-2/

Comment 12

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Comment on attachment 8902865 [details]
Bug 1395189 - Add reftest for default directions of prefixed linear gradients

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/174558/diff/2-3/

Comment 13

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

We also needed to update points_downwards method to handle this.

Comment 14

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Comment on attachment 8902865 [details]
Bug 1395189 - Add reftest for default directions of prefixed linear gradients

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/174558/diff/3-4/

Comment 15

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Servo side: https://github.com/servo/servo/pull/18321

Comment 16

[Bobby Holley (:bholley)]

Looks like the PR landed, NI Nazim to land the testcase.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d98a26d6f1c7
Add reftest for default directions of prefixed linear gradients r=manishearth

Comment 18

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Oops, landed the testcase.

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d98a26d6f1c7