Closed Bug 1395195 Opened 2 years ago Closed 2 years ago

Assertion failure: aChannels

Categories

(Core :: Web Audio, defect, P1)

x86_64
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: jkratzer, Assigned: achronop)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, regression, testcase, Whiteboard: [fuzzblocker])

Attachments

(3 files)

Attached file trigger.html
Testcase found while fuzzing mozilla-central rev 20170829-db7f19e26e57.  Testcase appears to only trigger on certain OS configurations.
Attached file Minidump stacktrace
It appears that the test case will only reproduce on systems which do not have a sound card.
What platform?
Component: Audio/Video → Web Audio
Flags: needinfo?(jkratzer)
(In reply to Alex Chronopoulos [:achronop] from comment #3)
> What platform?

Tested on Linux 64-bit
Flags: needinfo?(jkratzer)
Assertion failure: aChannels, at /builds/worker/workspace/build/src/dom/media/AudioBufferUtils.h:129

0|0|libxul.so|mozilla::AudioCallbackDriver::AudioCallbackDriver|hg:hg.mozilla.org/integration/mozilla-inbound:dom/media/AudioBufferUtils.h:f8e3ab3bb127|43|0x1a
0|1|libxul.so|mozilla::MediaStreamGraphImpl::MediaStreamGraphImpl|hg:hg.mozilla.org/integration/mozilla-inbound:dom/media/MediaStreamGraph.cpp:f8e3ab3bb127|3475|0x5
0|2|libxul.so|mozilla::MediaStreamGraph::GetInstance|hg:hg.mozilla.org/integration/mozilla-inbound:dom/media/MediaStreamGraph.cpp:f8e3ab3bb127|3576|0x5
0|3|libxul.so|mozilla::dom::AudioDestinationNode::AudioDestinationNode|hg:hg.mozilla.org/integration/mozilla-inbound:dom/media/webaudio/AudioDestinationNode.cpp:f8e3ab3bb127|339|0x7
0|4|libxul.so|mozilla::dom::AudioContext::AudioContext|hg:hg.mozilla.org/integration/mozilla-inbound:dom/media/webaudio/AudioContext.cpp:f8e3ab3bb127|152|0x16

Suspect
http://searchfox.org/mozilla-central/rev/51b3d67a5ec1758bd2fe7d7b6e75ad6b6b5da223/dom/media/AudioBufferUtils.h#129
from changes for bug 1378070.
Blocks: 1393585
Keywords: regression
(Assuming :karlt meant to block bug 1378070.)
Blocks: 1378070
No longer blocks: 1393585
Alex, can you fix this one ?
Flags: needinfo?(achronop)
Assignee: nobody → achronop
Rank: 15
Flags: needinfo?(achronop)
OS: Unspecified → Linux
Priority: -- → P1
Hardware: Unspecified → x86_64
When no sound card present method CubebUtils::MaxNumberOfChannels() returns zero and we try to instantiate `AudioCallbackDriver::mScratchBuffer` and `AudioCallbackDriver::mBuffer` with zero number of channels. I will create a patch to restrict the min number of channel to 1 on AudioCallbackDriver's helper audio buffers.
Comment on attachment 8903144 [details]
Bug 1395195 - Restrict min number of channels on AudioCallbackDriver's helper buffers.

https://reviewboard.mozilla.org/r/174932/#review180032
Attachment #8903144 - Flags: review?(padenot) → review+
Pushed by achronop@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/787441c9619d
Restrict min number of channels on AudioCallbackDriver's helper buffers. r=padenot
https://hg.mozilla.org/mozilla-central/rev/787441c9619d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.