Closed Bug 1395394 Opened 5 years ago Closed 5 years ago

Crash in mozilla::gfx::gfxGradientCache::GetGradientStops


(Core :: Web Painting, defect)

Windows 10
Not set



Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 --- fixed


(Reporter: marcia, Assigned: bas.schouten)



(Keywords: crash, regression, topcrash)

Crash Data


(1 file)

This bug was filed from the Socorro interface and is 
report bp-34118bd6-00a1-4176-b2b5-130130170825.

Seen while looking at crash stats: Looks as if first crash occurred in 20170817100132 build. So far 12 crashes/9 installs

Possible regression range based on Build ID:
It is my report.
Though I need to make sure, my prediction is that probably omtp is related to the crash...
(In a time frame I reported crashes(1/3 of all recent reports!), omtp is enabled)
OK, I tested without omtp for a while, and I can't reproduce this crash at all.
So, apparently, this crash is triggered by omtp.
Is omtp shipping in 57?
Flags: needinfo?(yamadat501)
No, I enabled it through about:config.
Flags: needinfo?(yamadat501)
According to Bas/milan on #gfx, omtp won't ship in 57. Updating.
Now that OMTP is enabled by default on Windows ( I think you might want to fix this crash. It crashes frequently (not always tho) here, for example on this site
There are 241 crashes in nightly 58 starting with buildid 20170929220356. Before this build, this crash was quite rare.
The signature is now ranked #8 for nightly top-crashers for content process.
:bas, could you investigate please ?
Flags: needinfo?(bas)
Keywords: topcrash
Bas, two thoughts: First, we skip this code when recording. It looks like it should be supported by capturing though. Second, GradientStops is not threadsafe-refcounted, so maybe there is a race between the cache and paint thread.

Flags: needinfo?(bas)
Comment on attachment 8914128 [details]
Bug 1395394: Make refcounting of GradientStops threadsafe for the sake of OMTP.
Attachment #8914128 - Flags: review?(matt.woodrow) → review+
This is the #2 Windows topcrash in Nightly 20170929220356.
Pushed by
Make refcounting of GradientStops threadsafe for the sake of OMTP. r=mattwoodrow
Assignee: nobody → bas
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Duplicate of this bug: 1404655
You need to log in before you can comment on or make changes to this bug.