Page action notifications should be anchored on relevant urlbar button, not main button, if present

RESOLVED FIXED in Firefox 57

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: adw, Assigned: adw)

Tracking

unspecified
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The BrowserPageActionFeedback notification is always anchored on the main page action button, but IMO it should be anchored on the relevant button if it's present.  For example, if the send to device button is in the urlbar, and you open its panel that way, the notification should be anchored on that button.

Should be an easy fix.
(Assignee)

Updated

2 years ago
Assignee: nobody → adw
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Oh, the code is already doing this.  But it doesn't look like it's working quite right?
(Assignee)

Comment 2

2 years ago
Yeah, not for the send to device panel.  I'll have a patch soon.
Thanks for catching this with the 'send to device' action.

UX requested that the confirmation popup be anchored to the button that was used to perform the action. If the urlbar button was clicked then it should anchor to the urlbar button. If the button within the page action popup was clicked then it should anchor to the "..." button.
(Assignee)

Comment 5

2 years ago
This builds on the patches in bug 1395398 and bug 1395154.

Comment 7

2 years ago
mozreview-review
Comment on attachment 8903376 [details]
Bug 1395410 - Page action notifications should be anchored on relevant urlbar button, not main button, if present.

https://reviewboard.mozilla.org/r/175192/#review180586
Attachment #8903376 - Flags: review?(jaws) → review+

Comment 8

2 years ago
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df6c53162e4e
Page action notifications should be anchored on relevant urlbar button, not main button, if present. r=jaws
https://hg.mozilla.org/mozilla-central/rev/df6c53162e4e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.