Closed Bug 1395456 Opened 4 years ago Closed 3 years ago
Ensure we generate correct min/max versions for the new langpacks
59 bytes, text/x-review-board-request
In bug 1393147 we updated the build code for the new language packs. In it, we're building the `strict_min_version` and `strict_max_version` for each manifest.json based on `MOZ_APP_VERSION`  I'm not sure if the code does the right thing by placing the MOZ_APP_VERSION as the `strict_min_version` and building `strict_max_version` just by adding `.*`. In particular, it seems that for Nightly MOZ_APP_VERSION equals `57.0a1` so, the `strict_max_version` ends up with `57.0a1.*` which feels wrong.  http://searchfox.org/mozilla-central/rev/51b3d67a5ec1758bd2fe7d7b6e75ad6b6b5da223/toolkit/locales/l10n.mk#219
Priority: -- → P3
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Comment on attachment 8903264 [details] Bug 1395456 - Use MOZ_APP_MAXVERSION for strict_max_version in langpack manifest. https://reviewboard.mozilla.org/r/175054/#review180998
Attachment #8903264 - Flags: review?(l10n) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/683153eaa16a Use MOZ_APP_MAXVERSION for strict_max_version in langpack manifest. r=Pike
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe verify-“ flag. Thanks!
Flags: needinfo?(gandalf) → qe-verify-
You need to log in before you can comment on or make changes to this bug.