Ensure we generate correct min/max versions for the new langpacks

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: zbraniecki, Assigned: zbraniecki)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

In bug 1393147 we updated the build code for the new language packs.
In it, we're building the `strict_min_version` and `strict_max_version` for each manifest.json based on `MOZ_APP_VERSION` [0]

I'm not sure if the code does the right thing by placing the MOZ_APP_VERSION as the `strict_min_version` and building `strict_max_version` just by adding `.*`.

In particular, it seems that for Nightly MOZ_APP_VERSION equals `57.0a1` so, the `strict_max_version` ends up with `57.0a1.*` which feels wrong.


[0] http://searchfox.org/mozilla-central/rev/51b3d67a5ec1758bd2fe7d7b6e75ad6b6b5da223/toolkit/locales/l10n.mk#219
Blocks: 1395363
Priority: -- → P3
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Comment on attachment 8903264 [details]
Bug 1395456 - Use MOZ_APP_MAXVERSION for strict_max_version in langpack manifest.

https://reviewboard.mozilla.org/r/175054/#review180998
Attachment #8903264 - Flags: review?(l10n) → review+
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/683153eaa16a
Use MOZ_APP_MAXVERSION for strict_max_version in langpack manifest. r=Pike
https://hg.mozilla.org/mozilla-central/rev/683153eaa16a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe verify-“ flag.
Thanks!
Flags: needinfo?(gandalf)
Flags: needinfo?(gandalf) → qe-verify-
You need to log in before you can comment on or make changes to this bug.