Child processes fail to start while the profiler is active in the parent process with a fractional sampling interval if the system locale's decimal separator is a comma

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

({regression})

Trunk
mozilla57
regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 wontfix, firefox57 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

a year ago
STR:
 1. Set your system locale to French or German.
 2. Set the Gecko profiler add-on's sampling interval to 0.9ms.
 3. Close all tabs except one.
 4. Grab a profile. The perf-html.io tab that opens creates a new process.

Actual results:
The perf-html.io tab that opens immediately "crashes".
(Assignee)

Updated

a year ago
OS: Unspecified → All
Hardware: Unspecified → All
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Summary: Child processes fail to start while the profiler is active in the parent process with a fractional sampling interval and the system locale's decimal separator is a comma → Child processes fail to start while the profiler is active in the parent process with a fractional sampling interval if the system locale's decimal separator is a comma

Comment 3

a year ago
mozreview-review
Comment on attachment 8903120 [details]
Bug 1395524 - Add profiler log messages for invalid startup profiling env vars.

https://reviewboard.mozilla.org/r/174918/#review180244
Attachment #8903120 - Flags: review?(n.nethercote) → review+

Comment 4

a year ago
mozreview-review
Comment on attachment 8903121 [details]
Bug 1395524 - Use AppendFloat when converting the float interval to the env var string.

https://reviewboard.mozilla.org/r/174920/#review180250
Attachment #8903121 - Flags: review?(n.nethercote) → review+

Comment 5

a year ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/28d54da51af5
Add profiler log messages for invalid startup profiling env vars. r=njn
https://hg.mozilla.org/integration/autoland/rev/3f011ef04279
Use AppendFloat when converting the float interval to the env var string. r=njn

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/28d54da51af5
https://hg.mozilla.org/mozilla-central/rev/3f011ef04279
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
status-firefox-esr52: --- → unaffected
status-firefox56: affected → wontfix
You need to log in before you can comment on or make changes to this bug.