1395651 - Change tab accent color to reflect new Photon spec

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Amin Al Hazwani [:amin] (Firefox UX)]

The tab accent color of default/light/dark theme is set to #0069d9 (aka highlight keyword) instead of Photon Blue 50 #0a84ff as documented here http://design.firefox.com/photon/visual/color.html#blue and here http://design.firefox.com/people/shorlander/photon/Mockups/macOS.html

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

For DevTools photon, we are aligning with the "highlight" keyword until this is also changed to blue-50 in Firefox Photon (Bug 1396393). When this bug is being fixed, please also consider changing our tab line color variable.

Comment 2

[Dão Gottwald [:dao]]

IIRC, in yesterday's photon-visual meeting, Stephen said we should keep Highlight for the default theme but use the custom blue for the Light/Dark themes.

Comment 3

[Stephen Horlander [:shorlander]]

(In reply to Dão Gottwald [::dao] from comment #2)
> IIRC, in yesterday's photon-visual meeting, Stephen said we should keep
> Highlight for the default theme but use the custom blue for the Light/Dark
> themes.

I was specifically talking about Linux here.

The only time we need to use the system colors is when we can't control the color of the surrounding elements.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1395651 - Set the tab line color to #0a84ff (blue-50) when we control the tabs toolbar background color.

Review commit: https://reviewboard.mozilla.org/r/181676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181676/

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 8910180 [details]
Bug 1395651 - Set the tab line color to #0a84ff (blue-50) when we control the tabs toolbar background color.

https://reviewboard.mozilla.org/r/181676/#review187494

Look sgood, cheers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8b5d382ff56
Set the tab line color to #0a84ff (blue-50) when we control the tabs toolbar background color. r=daleharvey

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c8b5d382ff56

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8910180 [details]
Bug 1395651 - Set the tab line color to #0a84ff (blue-50) when we control the tabs toolbar background color.

Approval Request Comment
[Feature/Bug causing the regression]: photon-visual polish
[User impact if declined]:
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple enough, straightforward fix
[String changes made/needed]: /

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8910180 [details]
Bug 1395651 - Set the tab line color to #0a84ff (blue-50) when we control the tabs toolbar background color.

p1 bug on photon, taking it!
Should be in 57b3

Comment 10

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-beta/rev/58b2863e4c86de541bed3376dff2f97ca7c0f1da

Comment 11

[Valentina Claudia Ona]

Hi Amin, 
Please tell me how I can make badges appear?

Comment 12

[Dão Gottwald [:dao]]

(In reply to Valentina Claudia Ona from comment #11)
> Hi Amin, 
> Please tell me how I can make badges appear?

What badges? This bug is about the highlight line on the selected tab.

Comment 13

[Valentina Claudia Ona]

Sorry about my mistake. 
I verified this issue and the color is #0A84FF, which is correct.
I will mark this as verified fixed.

Comment 14

[Valentina Claudia Ona]

Build ID 20170925220207
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Tested on Windows 10 x64,Windows 7 x32, Mac OS X 10.12

Comment 15

[Alexandru Simonca [:asimonca], Release Desktop QA]

Verified fixed on Windows 10 x64, Windows 7 x64 and macOS 10.13 using Firefox 57.0b9 and the default/light/dark themes.