Closed Bug 1395651 Opened 2 years ago Closed 2 years ago

Change tab accent color to reflect new Photon spec

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: amin, Assigned: dao)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(1 file)

The tab accent color of default/light/dark theme is set to #0069d9 (aka highlight keyword) instead of Photon Blue 50 #0a84ff as documented here http://design.firefox.com/photon/visual/color.html#blue and here http://design.firefox.com/people/shorlander/photon/Mockups/macOS.html
Blocks: photon-tabs
Priority: -- → P4
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
For DevTools photon, we are aligning with the "highlight" keyword until this is also changed to blue-50 in Firefox Photon (Bug 1396393). When this bug is being fixed, please also consider changing our tab line color variable.
IIRC, in yesterday's photon-visual meeting, Stephen said we should keep Highlight for the default theme but use the custom blue for the Light/Dark themes.
(In reply to Dão Gottwald [::dao] from comment #2)
> IIRC, in yesterday's photon-visual meeting, Stephen said we should keep
> Highlight for the default theme but use the custom blue for the Light/Dark
> themes.

I was specifically talking about Linux here.

The only time we need to use the system colors is when we can't control the color of the surrounding elements.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: P4 → P1
Iteration: --- → 57.3 - Sep 19
QA Contact: ovidiu.boca
Comment on attachment 8910180 [details]
Bug 1395651 - Set the tab line color to #0a84ff (blue-50) when we control the tabs toolbar background color.

https://reviewboard.mozilla.org/r/181676/#review187494

Look sgood, cheers
Attachment #8910180 - Flags: review?(dharvey) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c8b5d382ff56
Set the tab line color to #0a84ff (blue-50) when we control the tabs toolbar background color. r=daleharvey
Iteration: 57.3 - Sep 19 → ---
https://hg.mozilla.org/mozilla-central/rev/c8b5d382ff56
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8910180 [details]
Bug 1395651 - Set the tab line color to #0a84ff (blue-50) when we control the tabs toolbar background color.

Approval Request Comment
[Feature/Bug causing the regression]: photon-visual polish
[User impact if declined]:
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple enough, straightforward fix
[String changes made/needed]: /
Attachment #8910180 - Flags: approval-mozilla-beta?
Comment on attachment 8910180 [details]
Bug 1395651 - Set the tab line color to #0a84ff (blue-50) when we control the tabs toolbar background color.

p1 bug on photon, taking it!
Should be in 57b3
Attachment #8910180 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Hi Amin, 
Please tell me how I can make badges appear?
Flags: needinfo?(aalhazwani)
(In reply to Valentina Claudia Ona from comment #11)
> Hi Amin, 
> Please tell me how I can make badges appear?

What badges? This bug is about the highlight line on the selected tab.
Sorry about my mistake. 
I verified this issue and the color is #0A84FF, which is correct.
I will mark this as verified fixed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Build ID 20170925220207
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Tested on Windows 10 x64,Windows 7 x32, Mac OS X 10.12
Flags: needinfo?(aalhazwani)
Verified fixed on Windows 10 x64, Windows 7 x64 and macOS 10.13 using Firefox 57.0b9 and the default/light/dark themes.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.