1395711 - Enable dump() by default in local builds

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement)

Description

[Kris Maglione [:kmag]]

Since bug 379797 landed, a lot of people have been running into dump() suddenly not working by default, and having no idea why. Since dump() is commonly used for debugging in local builds, we should enable it there by default, the same way we do for the browser toolbox.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1395711: Enable dump() by default in local builds.

Review commit: https://reviewboard.mozilla.org/r/175090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175090/

Comment 2

[Brian Grinstead [:bgrins]]

I agree with making this the default behavior in local builds. There are two main ways we could do it:

1) A sticky_pref based on MOZILLA_OFFICIAL as in Bug 1375280. This would ensure any local build running with any profile would always have dump() enabled.
2) A mach run preference setting for the scratch user as in Bug 1172574. This would apply only for the scratch_user.

I think (1) would be best in this case, since it seems like the right default for all profiles / any way of running a locally built binary.

Comment 3

[Kris Maglione [:kmag]]

In that case... :)

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8903293 [details]
Bug 1395711: Enable dump() by default in local builds.

https://reviewboard.mozilla.org/r/175090/#review180148

Thanks, looks good to me!

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/faa9ec784d9dfb36b5bd77e85fc93e034a03a004
Bug 1395711: Enable dump() by default in local builds. r=jryans

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8903293 [details]
Bug 1395711: Enable dump() by default in local builds.

Clearing review flag since this landed

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/faa9ec784d9d