Closed Bug 1395711 Opened 2 years ago Closed 2 years ago

Enable dump() by default in local builds

Categories

(Core :: XPConnect, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

(Whiteboard: [browser-debugging-issues])

Attachments

(1 file)

Since bug 379797 landed, a lot of people have been running into dump() suddenly not working by default, and having no idea why. Since dump() is commonly used for debugging in local builds, we should enable it there by default, the same way we do for the browser toolbox.
I agree with making this the default behavior in local builds. There are two main ways we could do it:

1) A sticky_pref based on MOZILLA_OFFICIAL as in Bug 1375280. This would ensure any local build running with any profile would always have dump() enabled.
2) A mach run preference setting for the scratch user as in Bug 1172574. This would apply only for the scratch_user.

I think (1) would be best in this case, since it seems like the right default for all profiles / any way of running a locally built binary.
Attachment #8903293 - Flags: review?(jryans) → review?(bgrinstead)
In that case... :)
Comment on attachment 8903293 [details]
Bug 1395711: Enable dump() by default in local builds.

https://reviewboard.mozilla.org/r/175090/#review180148

Thanks, looks good to me!
Attachment #8903293 - Flags: review+
Comment on attachment 8903293 [details]
Bug 1395711: Enable dump() by default in local builds.

Clearing review flag since this landed
Attachment #8903293 - Flags: review?(bgrinstead)
https://hg.mozilla.org/mozilla-central/rev/faa9ec784d9d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.