1395713 - Turn on layers-free for async-scrolling reftests

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

In terms of the reftests in layout/reftests/async-scrolling, we're basically at parity between layers-full and layers-free WR. Here's a try push showing what happens when I turn on layers-free for this folder:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e65ae1e77d0967c2b65939bbb40b381442c0a72b

Basically the sticky-positioned tests swap (the one that failed now passes, the one that passed now fails) which is not meaningful because we haven't actually implemented sticky-positioning support on the gecko side yet. And there's a few perspective scrolling tests that are now passing.

I think we should turn on layers-free for this folder by default. I would prefer if we also just stopped running the tests in layers-full mode but I'm not sure if everybody would agree on that. My reasoning is that we've been encouraging everybody who wants to try webrender to use layers-free, so I don't expect a lot of people to be running layers-full; if we regress behaviour in that mode we can just ask them to switch to layers-free.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c85a430b1cb9ffd8868c3ac21909c24a780b2812

Comment 2

[Kartikaya Gupta (email:[e-mail])]

The above try push has the annotations updated, but there's still orange. It looks like the results are a little nondeterministic? Maybe we're not snapshotting at the right time in layers-free.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Disregard comment 2. I just screwed up the annotations. This one should be better:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=73f2972470393c481cfc42a333627e1cc8480011

Comment 4

[Jeff Muizelaar [:jrmuizel]]

(In reply to Kartikaya Gupta (Away Sep02-Sep10) (email:[e-mail]) from comment #0)
> 
> I think we should turn on layers-free for this folder by default. I would
> prefer if we also just stopped running the tests in layers-full mode but I'm
> not sure if everybody would agree on that. My reasoning is that we've been
> encouraging everybody who wants to try webrender to use layers-free, so I
> don't expect a lot of people to be running layers-full; if we regress
> behaviour in that mode we can just ask them to switch to layers-free.

This sounds reasonable to me.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1395713 - Run async-scrolling reftests in layers-free mode for webrender.

Review commit: https://reviewboard.mozilla.org/r/175382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175382/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

This needs to land after bug 1395670.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8903580 [details]
Bug 1395713 - Run async-scrolling reftests in layers-free mode for webrender.

https://reviewboard.mozilla.org/r/175382/#review180512

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80ac7149a182
Run async-scrolling reftests in layers-free mode for webrender. r=jrmuizel

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/80ac7149a182