Closed Bug 1395713 Opened 7 years ago Closed 7 years ago

Turn on layers-free for async-scrolling reftests

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

In terms of the reftests in layout/reftests/async-scrolling, we're basically at parity between layers-full and layers-free WR. Here's a try push showing what happens when I turn on layers-free for this folder:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e65ae1e77d0967c2b65939bbb40b381442c0a72b

Basically the sticky-positioned tests swap (the one that failed now passes, the one that passed now fails) which is not meaningful because we haven't actually implemented sticky-positioning support on the gecko side yet. And there's a few perspective scrolling tests that are now passing.

I think we should turn on layers-free for this folder by default. I would prefer if we also just stopped running the tests in layers-full mode but I'm not sure if everybody would agree on that. My reasoning is that we've been encouraging everybody who wants to try webrender to use layers-free, so I don't expect a lot of people to be running layers-full; if we regress behaviour in that mode we can just ask them to switch to layers-free.
The above try push has the annotations updated, but there's still orange. It looks like the results are a little nondeterministic? Maybe we're not snapshotting at the right time in layers-free.
(In reply to Kartikaya Gupta (Away Sep02-Sep10) (email:kats@mozilla.com) from comment #0)
> 
> I think we should turn on layers-free for this folder by default. I would
> prefer if we also just stopped running the tests in layers-full mode but I'm
> not sure if everybody would agree on that. My reasoning is that we've been
> encouraging everybody who wants to try webrender to use layers-free, so I
> don't expect a lot of people to be running layers-full; if we regress
> behaviour in that mode we can just ask them to switch to layers-free.

This sounds reasonable to me.
This needs to land after bug 1395670.
Depends on: 1395670
Comment on attachment 8903580 [details]
Bug 1395713 - Run async-scrolling reftests in layers-free mode for webrender.

https://reviewboard.mozilla.org/r/175382/#review180512
Attachment #8903580 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80ac7149a182
Run async-scrolling reftests in layers-free mode for webrender. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/80ac7149a182
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: