Closed Bug 1395733 Opened 2 years ago Closed 2 years ago

Toggling "unwanted and uncommon" off and back on leaves users with an unnecessary customized pref

Categories

(Toolkit :: Safe Browsing, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: francois, Assigned: francois)

References

Details

(Keywords: regression, Whiteboard: #sbv4-m9)

Attachments

(1 file)

Steps:

1. Open about:preferences
2. Under Privacy & Security | Security | Phishing Protection
3. Untick "Warn you about unwanted and uncommon software"
4. Tick it back again.
5. Look for urlclassifier.malwareTable in about:config

Expected:

The pref is set back to its default value (i.e. not bold):

  goog-malware-proto,goog-unwanted-proto,test-malware-simple,test-unwanted-simple,test-harmful-simple

Actual:

The pref is shown as customized (i.e. in bold) and set to:

  goog-malware-proto,goog-unwanted-proto,,test-harmful-simple,test-malware-simple,test-unwanted-simple


The fix is to ensure that the default value of this pref is sorted:

browser/app/profile/firefox.js
modules/libpref/init/all.js
Comment on attachment 8903366 [details]
Bug 1395733 - Ensure the default value of urlclassifier.malwareTable is always sorted.

https://reviewboard.mozilla.org/r/175168/#review180350
Attachment #8903366 - Flags: review?(gpascutto) → review+
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9a66967ab703
Ensure the default value of urlclassifier.malwareTable is always sorted. r=gcp
https://hg.mozilla.org/mozilla-central/rev/9a66967ab703
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57

Hi,

I have managed to reproduce the issue on latest Nightly 70.0a1 (2019-07-16) on all OS-es. Should I reopen this bug or log a new one?

Thanks.

Flags: needinfo?(francois)

Probably best to open a new bug (regression) and link back to this one.

Flags: needinfo?(francois)
See Also: → 1567076
You need to log in before you can comment on or make changes to this bug.