1395733 - Toggling "unwanted and uncommon" off and back on leaves users with an unnecessary customized pref

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P1)

Description

[François Marier [:francois]]

Steps:

1. Open about:preferences
2. Under Privacy & Security | Security | Phishing Protection
3. Untick "Warn you about unwanted and uncommon software"
4. Tick it back again.
5. Look for urlclassifier.malwareTable in about:config

Expected:

The pref is set back to its default value (i.e. not bold):

  goog-malware-proto,goog-unwanted-proto,test-malware-simple,test-unwanted-simple,test-harmful-simple

Actual:

The pref is shown as customized (i.e. in bold) and set to:

  goog-malware-proto,goog-unwanted-proto,,test-harmful-simple,test-malware-simple,test-unwanted-simple


The fix is to ensure that the default value of this pref is sorted:

browser/app/profile/firefox.js
modules/libpref/init/all.js

Comment 1

[François Marier [:francois]]

Attachment: Bug 1395733 - Ensure the default value of urlclassifier.malwareTable is always sorted.

Review commit: https://reviewboard.mozilla.org/r/175168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175168/

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8903366 [details]
Bug 1395733 - Ensure the default value of urlclassifier.malwareTable is always sorted.

https://reviewboard.mozilla.org/r/175168/#review180350

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a66967ab703
Ensure the default value of urlclassifier.malwareTable is always sorted. r=gcp

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9a66967ab703

Comment 5

[Alin Ilea, Desktop Test Engineering]

Hi,

I have managed to reproduce the issue on latest Nightly 70.0a1 (2019-07-16) on all OS-es. Should I reopen this bug or log a new one?

Thanks.

Comment 6

[François Marier [:francois]]

Probably best to open a new bug (regression) and link back to this one.