Closed
Bug 1395761
Opened 7 years ago
Closed 7 years ago
Highlights icons not centered
Categories
(Firefox for Android Graveyard :: Awesomescreen, enhancement, P1)
Tracking
(fennec+, firefox55 unaffected, firefox56 unaffected, firefox57 verified)
VERIFIED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
fennec | + | --- |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | verified |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
(Whiteboard: [mobileAS])
Attachments
(5 files)
Highlights icons are intentionally wider than they are tall but it looks like the icons we provide are not centered - which is weird because I could have sworn they were fitCenter. See the attached screenshot.
Updated•7 years ago
|
Priority: -- → P2
Updated•7 years ago
|
tracking-fennec: ? → +
Updated•7 years ago
|
Rank: 2
Assignee | ||
Comment 1•7 years ago
|
||
I discovered the margin seems to push the view to one side: see the attached screenshot. I removed the margins and the view is correctly centered - yay! So we need to figure out why the other views aren't resizing to take into account the added margin.
Updated•7 years ago
|
Iteration: --- → 1.30
Rank: 2
Priority: P2 → P1
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → michael.l.comella
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 5•7 years ago
|
||
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8906677 [details] Bug 1395761: Remove layout_gravity=center in webpage_item_row. https://reviewboard.mozilla.org/r/178396/#review183378 Simple change, fixes the layout, lgtm.
Attachment #8906677 -
Flags: review?(liuche) → review+
Pushed by michael.l.comella@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ab339292ac6b Remove layout_gravity=center in webpage_item_row. r=liuche
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ab339292ac6b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
Comment 9•7 years ago
|
||
Icons are now centered on both phones and tablets. Marking as verified.
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•