1395761 - Highlights icons not centered

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, enhancement, P1)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

Highlights icons are intentionally wider than they are tall but it looks like the icons we provide are not centered - which is weird because I could have sworn they were fitCenter. See the attached screenshot.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot: layout bounds

I discovered the margin seems to push the view to one side: see the attached screenshot.

I removed the margins and the view is correctly centered - yay!

So we need to figure out why the other views aren't resizing to take into account the added margin.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1395761: Remove layout_gravity=center in webpage_item_row.

This has the effect of:
- Aligning the webpage item row with top sites (both 10dp margins)
- Making the icons not cut off

Unfortunately, I don't know why this solved the problem considering the size of
the container did not change. However, the layout_gravity was extraneous and
given all the other work we have to do, I'm fine not researching further.

One thing I noticed is that with layout_gravity, there was an additional
non-colored space in the "Show Layout Bounds" mode with layout_gravity than
there was with out it.

Review commit: https://reviewboard.mozilla.org/r/178396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178396/

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot post-patch

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot post-patch: layout bounds

Comment 6

[Chenxia Liu [:liuche]]

Comment on attachment 8906677 [details]
Bug 1395761: Remove layout_gravity=center in webpage_item_row.

https://reviewboard.mozilla.org/r/178396/#review183378

Simple change, fixes the layout, lgtm.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab339292ac6b
Remove layout_gravity=center in webpage_item_row. r=liuche

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ab339292ac6b

Comment 9

[Bogdan Surd, QA [:bsurd, NI]]

Icons are now centered on both phones and tablets. Marking as verified.