1395768 - bootstrap doesn't find mach on fresh clones

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Henri Kemppainen]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170816212843

Steps to reproduce:

1. Run bootstrap.py, but not within an existing clone
2. Select firefox for desktop and follow prompts
3. When asked for directory for clone, enter a relative path (e.g. mozilla-unified)
4. Sit back



Actual results:

Clone goes fine.  install_tooltool_clang_package tries to run mozilla-unified/mach artifact toolchain in ~/.mozbuild/.  Of course, mozilla-unified/mach does not exist in ~/.mozbuild/:

/usr/bin/python2.7: can't open file 'mozilla-unified/mach': [Errno 2] No such file or directory


Expected results:

Use absolute path, and download clang successfully.

Comment 1

[Henri Kemppainen]

Attachment: bootstrap-mach-abspath.patch

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8903384 [details] [diff] [review]
bootstrap-mach-abspath.patch

Review of attachment 8903384 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks for the bug report and fix. Someone will land this shortly.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/301ee7d2eb05
Use absolute path to mach. r=gps

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/301ee7d2eb05