Closed
Bug 1395768
Opened 7 years ago
Closed 7 years ago
bootstrap doesn't find mach on fresh clones
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: mozilla, Assigned: mozilla)
Details
Attachments
(1 file)
|
795 bytes,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 Build ID: 20170816212843 Steps to reproduce: 1. Run bootstrap.py, but not within an existing clone 2. Select firefox for desktop and follow prompts 3. When asked for directory for clone, enter a relative path (e.g. mozilla-unified) 4. Sit back Actual results: Clone goes fine. install_tooltool_clang_package tries to run mozilla-unified/mach artifact toolchain in ~/.mozbuild/. Of course, mozilla-unified/mach does not exist in ~/.mozbuild/: /usr/bin/python2.7: can't open file 'mozilla-unified/mach': [Errno 2] No such file or directory Expected results: Use absolute path, and download clang successfully.
|
Assignee | |
Updated•7 years ago
|
Component: Untriaged → Build Config
Product: Firefox → Core
|
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8903384 -
Flags: review?(gps)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8903384 [details] [diff] [review] bootstrap-mach-abspath.patch Review of attachment 8903384 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thanks for the bug report and fix. Someone will land this shortly.
Attachment #8903384 -
Flags: review?(gps) → review+
|
|
||
Updated•7 years ago
|
Keywords: checkin-needed
|
||
Updated•7 years ago
|
Assignee: nobody → mozilla
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/301ee7d2eb05 Use absolute path to mach. r=gps
Keywords: checkin-needed
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/301ee7d2eb05
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•