139588 - TT 2.07 problem: newly added columns are only one (1) character wide

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Andreas Franke (gone)]

Newly added columns (via "Change Columns" link on buglist.cgi) have their
content values displayed only up to a width of a single character (*1*
character) if you use TT 2.07. According to myk it works fine on TT 2.06.

Comment 1

[Andreas Franke (gone)]

This is definitely a 2.16 issue.

Comment 2

[Andreas Franke (gone)]

So it turns out that there is at least another serious regression caused by the
new TT 2.07: The choose-product.html.tmpl (most easily triggered by
describecomponents.cgi or enter_bug.cgi ) only displays the values (and links to
the product) for the first product. There are table cells and colons for the
other products as well, but the content is missing completely for them.
Also, bug 139542 may be caused by TT 2.07, but that's just a guess, I haven't
verified it.

Probably the easiest solution is to warn people not to use TT 2.07 because it's
too buggy. 

Comment 3

[Bradley Baetz (:bbaetz)]

Err, no, we want to _require_ 2.07. I don't see this, nor do I see bug 139542.
I'm not too sure what I'm meant to see with your comment #0, mind you.

One thing you need to notice is that if you went from not using XS to using XS,
then the files are moved to the binary install directories, (ie i386-linux).
This may cause problems, somehow, if stuff is mixed, sepcially if somehow you
change which stash you are using half way through. Try deleting the old
installation first. To be safe, delete them both, and then reinstall 2.07. Does
that fix this problem, after reverting this patch?

Comment 4

[David D. Kilzer (ddk)]

Actually, the only column I'm seeing problems with after updating
to Template-Toolkit v2.07 is the TargetM[ilestone] column.  It's
only 1 column wide.

Comment 5

[David D. Kilzer (ddk)]

I found the problem.  In template/en/default/list/table.html.tmpl,
there is no 'size' parameter set for 'status_whiteboard' or for
'target_milestone'.

I believe 'target_milestone' should be set to 7 (which is
length('TargetM')), but I'm not sure what 'status_whiteboard'
should be set to, though it should probably have an elipses
set for it.

Comment 6

[David D. Kilzer (ddk)]

Attachment: Patch v.1

This fixed the TargetM[ilestone] column for me.  I don't use
the Status Whiteboard, so I can't test it locally, but the 
patch changes it to be identical to the Summary column (since
they are similar size in show_bug.cgi).

Comment 7

[David D. Kilzer (ddk)]

Note that the behaviour of the truncate() function may have changed
in TT 2.07, which could be the original culprit.  I haven't had
time to verify this, though.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Truncate is a Bugzilla function defined in globals.pl.  I think the problem here
is that TT 2.07 implements a built-in "size" function for hashes and is now
interpreting "abbrev.target_milestone.size" as "the size of the
abbrev.target_milestone hash" instead of "the value for the size key in the
abbrev.target_milestone hash" for abbreviation records with no size value.

Instead of adding a maximum size for these fields, which are not currently
restricted by size, we should change the name of this field from "size" to
"maxlength" or something similar so we don't run afoul of the "size" function.

Comment 9

[Bradley Baetz (:bbaetz)]

The problem is that our size atttribute will override teh builtin one, but if it
doesn't exist, then we fall back to TT's one, due to scoping rules, and that
will return 1. So the problem is that we relied on the size attribute possilby
not being present, and then TT made it always present. The best fix is to just
change the name.

Just to confirm, noone else is seeing the issue in comment #3?

Comment 10

[Gervase Markham [:gerv]]

Attachment: Patch v.2

As suggested - size -> maxlength. I don't have 2.07 yet, so I can't test if it
fixes the problem, but it should.

Gerv

Comment 11

[David D. Kilzer (ddk)]

Comment on attachment 80918 [details] [diff] [review]
Patch v.2

r=ddk  Works for me!  (Renamed to Patch v.2)

Comment 12

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 80918 [details] [diff] [review]
Patch v.2

Works. r=myk

Comment 13

[Myk Melez [:myk] [@mykmelez]]

Checking in template/en/default/list/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl,v 
<--  table.html.tmpl
new revision: 1.3; previous revision: 1.2
done