Closed Bug 1395911 Opened 3 years ago Closed 3 years ago
Ensure the addon options are not hidden when about:addons is already opened while a webextension is still starting
Unfortunately this scenario is missing from the test cases, because the extension is already started when we open its details in the "about:addons" page, and even the "addon disable/enable" test cases is not able to catch this issue because in that scenario the "optionsURL" attribute on the addon details HTML element has been already set to the real WebExtension optionsURL (which is only available once the addon has been started). Unfortunately, the entire "options box" element is hidden (from the aboutAddons.css CSS rules) when optionsURL is an empty string. A reasonable fix can be to remove the "optionsURL" attribute completely when the addon is a WebExtension (the attribute is not actually used for rendering the WebExtension options and the attribute will be added back when the user navigates on a legacy extension, which is the only scenario where that attribute is actually used).
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Priority: -- → P2
Comment on attachment 8903558 [details] Bug 1395911 - Ensure Android addon options are not hidden while a webextension is still starting. https://reviewboard.mozilla.org/r/175370/#review181052
Attachment #8903558 - Flags: review?(s.kaspari) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/fc5fc58f42a3 Ensure Android addon options are not hidden while a webextension is still starting. r=sebastian
This issue is verified as fixed on Fennec 57.0a1 (2017-09-07) under Android 6.0.1. Extension options are not hidden when about:addons is already opened and the extension is still starting. Please see the attached video.
You need to log in before you can comment on or make changes to this bug.