1395945 - Remove child array getter

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Cătălin Badea (:catalinb)]

This is an easy one. Get rid of ::GetChildArray.

Comment 1

[Cătălin Badea (:catalinb)]

Attachment: Remove child array getter.

Comment 2

[(no longer active)]

Comment on attachment 8903571 [details] [diff] [review]
Remove child array getter.

Review of attachment 8903571 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thank you!

::: dom/base/nsINode.h
@@ +1281,2 @@
>  
> +    return count > 0 ? GetChildAt(count - 1) : nullptr;

Hmm...  Do we have a plan to get rid of this call to GetChildAt() at some point too somehow?

Comment 3

[Cătălin Badea (:catalinb)]

(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #2)
> Comment on attachment 8903571 [details] [diff] [review]
> Remove child array getter.
> 
> Review of attachment 8903571 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Nice, thank you!
> 
> ::: dom/base/nsINode.h
> @@ +1281,2 @@
> >  
> > +    return count > 0 ? GetChildAt(count - 1) : nullptr;
> 
> Hmm...  Do we have a plan to get rid of this call to GetChildAt() at some
> point too somehow?

Yes, GetLastChild() will return mFirstChild->mPreviousChild which is the last child.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b137fb389c95
Remove child array getter. r=ehsan

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b137fb389c95