Closed Bug 1395954 Opened 7 years ago Closed 7 years ago

Remove unnecessary rooting in intrinsic_IsConstructor

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: anba, Assigned: anba)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Avoiding the extra rooting in intrinsic_IsConstructor makes it a bit faster (~10-20% in µ-benchmarks).
Attached patch bug1395954.patchSplinter Review
Attachment #8903583 - Flags: review?(till)
Comment on attachment 8903583 [details] [diff] [review]
bug1395954.patch

Review of attachment 8903583 [details] [diff] [review]:
-----------------------------------------------------------------

That's a surprisingly large difference. I'd have assumed this to be dominated by the call overhead much more.
Attachment #8903583 - Flags: review?(till) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ddbac4df595
Avoid unnecessay rooting in IsConstructor intrinsic function. r=till
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9ddbac4df595
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.