Closed
Bug 1395954
Opened 7 years ago
Closed 7 years ago
Remove unnecessary rooting in intrinsic_IsConstructor
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.12 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
Avoiding the extra rooting in intrinsic_IsConstructor makes it a bit faster (~10-20% in µ-benchmarks).
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8903583 -
Flags: review?(till)
Comment 2•7 years ago
|
||
Comment on attachment 8903583 [details] [diff] [review] bug1395954.patch Review of attachment 8903583 [details] [diff] [review]: ----------------------------------------------------------------- That's a surprisingly large difference. I'd have assumed this to be dominated by the call overhead much more.
Attachment #8903583 -
Flags: review?(till) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f757ace01ed8acdd25a22968507abe4c74c8525
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9ddbac4df595 Avoid unnecessay rooting in IsConstructor intrinsic function. r=till
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9ddbac4df595
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•